Nicolas' review

yceruto · yceruto · commit bbd806b7fecd · 2025-01-20T08:13:39.000-05:00
diff --git a/src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php b/src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php
@@ -53,6 +53,8 @@ public function process(ContainerBuilder $container): void
                 $invokableRef = new Reference($id);
                 $definition = $container->register($id .= '.command', $class = Command::class)
                     ->addMethodCall('setCode', [$invokableRef]);
+            } else {
+                $invokableRef = null;
             }
 
             $aliases = $tags[0]['command'] ?? str_replace('%', '%%', $class::getDefaultName() ?? '');
@@ -105,7 +107,7 @@ public function process(ContainerBuilder $container): void
                 $definition->addMethodCall('setHidden', [true]);
             }
 
-            if ($help && isset($invokableRef)) {
+            if ($help && $invokableRef) {
                 $definition->addMethodCall('setHelp', [str_replace('%', '%%', $help)]);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,8 @@ public function process(ContainerBuilder $container): void`
`53`	`53`	`$invokableRef = new Reference($id);`
`54`	`54`	`$definition = $container->register($id .= '.command', $class = Command::class)`
`55`	`55`	`->addMethodCall('setCode', [$invokableRef]);`
	`56`	`+ } else {`
	`57`	`+ $invokableRef = null;`
`56`	`58`	`}`
`57`	`59`
`58`	`60`	`$aliases = $tags[0]['command'] ?? str_replace('%', '%%', $class::getDefaultName() ?? '');`
`@@ -105,7 +107,7 @@ public function process(ContainerBuilder $container): void`
`105`	`107`	`$definition->addMethodCall('setHidden', [true]);`
`106`	`108`	`}`
`107`	`109`
`108`		`- if ($help && isset($invokableRef)) {`
	`110`	`+ if ($help && $invokableRef) {`
`109`	`111`	`$definition->addMethodCall('setHelp', [str_replace('%', '%%', $help)]);`
`110`	`112`	`}`
`111`	`113`