more improvements

yceruto · yceruto · commit bf1e2bbc4e87 · 2024-08-29T14:07:00.000-04:00
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Decorator/DoctrineTransactionDecoratorTest.php b/src/Symfony/Bridge/Doctrine/Tests/Decorator/DoctrineTransactionDecoratorTest.php
@@ -43,34 +43,26 @@ protected function setUp(): void
 
     public function testDecoratorWrapsInTransactionAndFlushes()
     {
-        $this->connection->expects($this->once())
-            ->method('beginTransaction')
-        ;
-        $this->connection->expects($this->once())
-            ->method('commit')
-        ;
-        $this->entityManager->expects($this->once())
-            ->method('flush')
-        ;
-
         $handler = new TestHandler();
+
+        $this->connection->expects($this->once())->method('beginTransaction');
+        $this->connection->expects($this->once())->method('commit');
+        $this->entityManager->expects($this->once())->method('flush');
+
         $result = $this->decorator->call($handler->handle(...));
         $this->assertSame('success', $result);
     }
 
     public function testTransactionIsRolledBackOnException()
     {
-        $this->connection->expects($this->once())
-            ->method('beginTransaction')
-        ;
-        $this->connection->expects($this->once())
-            ->method('rollBack')
-        ;
+        $this->connection->expects($this->once())->method('beginTransaction');
+        $this->connection->expects($this->once())->method('rollBack');
+
+        $handler = new TestHandler();
 
         $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('A runtime error.');
 
-        $handler = new TestHandler();
         $this->decorator->call($handler->handleWithError(...));
     }
 
@@ -79,11 +71,12 @@ public function testInvalidEntityManagerThrowsException()
         $this->managerRegistry
             ->method('getManager')
             ->with('unknown_manager')
-            ->will($this->throwException(new \InvalidArgumentException()));
+            ->willThrowException(new \InvalidArgumentException());
+
+        $handler = new TestHandler();
 
         $this->expectException(\InvalidArgumentException::class);
 
-        $handler = new TestHandler();
         $this->decorator->call($handler->handleWithUnknownManager(...));
     }
 }
