Skip to content

Commit c14554f

Browse files
weaverryanweaverryan
committed
avoid the void!
1 parent dd0ad20 commit c14554f

10 files changed

+26
-26
lines changed

‎src/Symfony/Component/Asset/Tests/Pipeline/AssetPipelineDevServerSubscriberFunctionalTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
class AssetPipelineDevServerSubscriberFunctionalTest extends WebTestCase
1818
{
19-
public function testGettingAssetWorks(): void
19+
public function testGettingAssetWorks()
2020
{
2121
$client = static::createClient();
2222

@@ -32,7 +32,7 @@ public function testGettingAssetWorks(): void
3232
$this->assertSame('immutable, public, s-maxage=604800', $response->headers->get('Cache-Control'));
3333
}
3434

35-
public function test404OnUnknownAsset(): void
35+
public function test404OnUnknownAsset()
3636
{
3737
$client = static::createClient();
3838

@@ -41,7 +41,7 @@ public function test404OnUnknownAsset(): void
4141
$this->assertSame(404, $response->getStatusCode());
4242
}
4343

44-
public function test404OnInvalidDigest(): void
44+
public function test404OnInvalidDigest()
4545
{
4646
$client = static::createClient();
4747

@@ -51,7 +51,7 @@ public function test404OnInvalidDigest(): void
5151
$this->assertStringContainsString('Asset "file1.css" was found but the digest does not match.', $response->getContent());
5252
}
5353

54-
public function testPreDigestedAssetIsReturned(): void
54+
public function testPreDigestedAssetIsReturned()
5555
{
5656
$client = static::createClient();
5757

‎src/Symfony/Component/Asset/Tests/Pipeline/AssetPipelineRepositoryTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
class AssetPipelineRepositoryTest extends TestCase
1818
{
19-
public function testFindWithAbsolutePaths(): void
19+
public function testFindWithAbsolutePaths()
2020
{
2121
$repository = new AssetPipelineRepository([
2222
__DIR__.'/../fixtures/pipeline/dir1',
@@ -29,7 +29,7 @@ public function testFindWithAbsolutePaths(): void
2929
$this->assertNull($repository->find('file5.css'));
3030
}
3131

32-
public function testFindWithRelativePaths(): void
32+
public function testFindWithRelativePaths()
3333
{
3434
$repository = new AssetPipelineRepository([
3535
'dir1',
@@ -42,7 +42,7 @@ public function testFindWithRelativePaths(): void
4242
$this->assertNull($repository->find('file5.css'));
4343
}
4444

45-
public function testAll(): void
45+
public function testAll()
4646
{
4747
$repository = new AssetPipelineRepository([
4848
'dir1',

‎src/Symfony/Component/Asset/Tests/Pipeline/AssetPipelineTest.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function testGetPublicPrefix()
4848
$this->assertSame('/publicPrefix/', $pipeline->getPublicPrefix());
4949
}
5050

51-
public function testGetAsset(): void
51+
public function testGetAsset()
5252
{
5353
$pipeline = $this->createPipeline();
5454
$this->assertNull($pipeline->getAsset('non-existent.js'));
@@ -58,30 +58,30 @@ public function testGetAsset(): void
5858
$this->assertMatchesRegularExpression('/^\/final-assets\/file2-[a-zA-Z0-9]{7,128}\.js$/', $asset->getPublicPath());
5959
}
6060

61-
public function testGetAssetRespectsPreDigestedPaths(): void
61+
public function testGetAssetRespectsPreDigestedPaths()
6262
{
6363
$pipeline = $this->createPipeline();
6464
$asset = $pipeline->getAsset('already-abcdefVWXYZ0123456789.digested.css');
6565
$this->assertSame('already-abcdefVWXYZ0123456789.digested.css', $asset->getLogicalPath());
6666
$this->assertSame('/final-assets/already-abcdefVWXYZ0123456789.digested.css', $asset->getPublicPath());
6767
}
6868

69-
public function testGetAssetUsesManifestIfAvailable(): void
69+
public function testGetAssetUsesManifestIfAvailable()
7070
{
7171
$pipeline = $this->createPipeline();
7272
$asset = $pipeline->getAsset('file4.js');
7373
$this->assertSame('/final-assets/file4.checksumfrommanifest.js', $asset->getPublicPath());
7474
}
7575

76-
public function testAllAssets(): void
76+
public function testAllAssets()
7777
{
7878
$pipeline = $this->createPipeline();
7979
$assets = $pipeline->allAssets();
8080
$this->assertCount(8, $assets);
8181
$this->assertInstanceOf(PipelinedAsset::class, $assets[0]);
8282
}
8383

84-
public function testGetContentBasic(): void
84+
public function testGetContentBasic()
8585
{
8686
$pipeline = $this->createPipeline();
8787
$expected = <<<EOF
@@ -95,7 +95,7 @@ public function testGetContentBasic(): void
9595
$this->assertSame($expected, $pipeline->getContent('file1.css'));
9696
}
9797

98-
public function testGetContentUsesCompilers(): void
98+
public function testGetContentUsesCompilers()
9999
{
100100
$pipeline = $this->createPipeline();
101101
$expected = <<<EOF
@@ -107,15 +107,15 @@ public function testGetContentUsesCompilers(): void
107107
$this->assertSame($expected, $pipeline->getContent('subdir/file5.js'));
108108
}
109109

110-
public function testGetContentErrorsOnCircularReferences(): void
110+
public function testGetContentErrorsOnCircularReferences()
111111
{
112112
$pipeline = $this->createPipeline('circular_dir');
113113
$this->expectException(\RuntimeException::class);
114114
$this->expectExceptionMessage('Circular reference detected while calculating file contents for "circular1.js": circular1.js -> circular2.js -> circular1.js.');
115115
$pipeline->getContent('circular1.js');
116116
}
117117

118-
public function testGetDigest(): void
118+
public function testGetDigest()
119119
{
120120
$file5Compiler = new class() implements AssetCompilerInterface {
121121
public function supports(string $mimeType): bool
@@ -143,7 +143,7 @@ public function compile(string $logicalPath, string $contents, AssetPipeline $pi
143143
$this->assertSame('8b904e7f25c13c307cd1292a1df2029b', $pipeline->getDigest('subdir/file6.js'));
144144
}
145145

146-
public function testGetMimeType(): void
146+
public function testGetMimeType()
147147
{
148148
$pipeline = $this->createPipeline();
149149
$this->assertSame('text/css', $pipeline->getMimeType('file1.css'));

‎src/Symfony/Component/Asset/Tests/Pipeline/Compiler/AssetCompilerPathResolverTraitTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class AssetCompilerPathResolverTraitTest extends TestCase
2020
/**
2121
* @dataProvider provideCompileTests
2222
*/
23-
public function testResolvePath(string $directory, string $filename, string $expectedPath): void
23+
public function testResolvePath(string $directory, string $filename, string $expectedPath)
2424
{
2525
$resolver = new StubTestAssetCompilerPathResolver();
2626
$this->assertSame($expectedPath, $resolver->doResolvePath($directory, $filename));
@@ -53,7 +53,7 @@ public function provideCompileTests(): iterable
5353
];
5454
}
5555

56-
public function testExceptionIfPathGoesAboveDirectory(): void
56+
public function testExceptionIfPathGoesAboveDirectory()
5757
{
5858
$this->expectException(RuntimeException::class);
5959
$this->expectExceptionMessage('Cannot import the file "../../other.js": it is outside the current "subdir" directory.');

‎src/Symfony/Component/Asset/Tests/Pipeline/Compiler/CssAssetUrlCompilerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class CssAssetUrlCompilerTest extends TestCase
2121
/**
2222
* @dataProvider provideCompileTests
2323
*/
24-
public function testCompile(string $sourceLogicalName, string $input, string $expectedOutput): void
24+
public function testCompile(string $sourceLogicalName, string $input, string $expectedOutput)
2525
{
2626
$pipeline = $this->createMock(AssetPipeline::class);
2727
$pipeline->expects($this->any())

‎src/Symfony/Component/Asset/Tests/Pipeline/Compiler/JavaScriptImportPathCompilerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class JavaScriptImportPathCompilerTest extends TestCase
2121
/**
2222
* @dataProvider provideCompileTests
2323
*/
24-
public function testCompile(string $sourceLogicalName, string $input, string $expectedOutput): void
24+
public function testCompile(string $sourceLogicalName, string $input, string $expectedOutput)
2525
{
2626
$pipeline = $this->createMock(AssetPipeline::class);
2727
$pipeline->expects($this->any())

‎src/Symfony/Component/Asset/Tests/Pipeline/Compiler/SourceMappingUrlsCompilerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class SourceMappingUrlsCompilerTest extends TestCase
2121
/**
2222
* @dataProvider provideCompileTests
2323
*/
24-
public function testCompile(string $sourceLogicalName, string $input, string $expectedOutput): void
24+
public function testCompile(string $sourceLogicalName, string $input, string $expectedOutput)
2525
{
2626
$pipeline = $this->createMock(AssetPipeline::class);
2727
$pipeline->expects($this->any())

‎src/Symfony/Component/Asset/Tests/Pipeline/PipelineAwareAssetPackageIntegrationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
class PipelineAwareAssetPackageIntegrationTest extends KernelTestCase
1919
{
20-
public function testDefaultAssetPackageIsDecorated(): void
20+
public function testDefaultAssetPackageIsDecorated()
2121
{
2222
$kernel = new PipelineTestAppKernel('test', true);
2323
$kernel->boot();

‎src/Symfony/Component/Asset/Tests/Pipeline/PipelineAwareAssetPackageTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
class PipelineAwareAssetPackageTest extends TestCase
2121
{
22-
public function testGetVersion(): void
22+
public function testGetVersion()
2323
{
2424
$inner = $this->createMock(PackageInterface::class);
2525
$inner->expects($this->once())
@@ -32,7 +32,7 @@ public function testGetVersion(): void
3232
$this->assertSame('2.0', $pipelinePackage->getVersion('foo'));
3333
}
3434

35-
public function testGetUrl(string $path, string $expectedPathSentToInner): void
35+
public function testGetUrl(string $path, string $expectedPathSentToInner)
3636
{
3737
$inner = $this->createMock(PackageInterface::class);
3838
$inner->expects($this->once())

‎src/Symfony/Component/Asset/Tests/Pipeline/PipelinedAssetTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function testGetters()
2727
/**
2828
* @dataProvider getExtensionTests
2929
*/
30-
public function testGetExtension(string $filename, string $expectedExtension): void
30+
public function testGetExtension(string $filename, string $expectedExtension)
3131
{
3232
$asset = new PipelinedAsset($filename, 'does-not-matter');
3333

@@ -44,7 +44,7 @@ public function getExtensionTests(): iterable
4444
/**
4545
* @dataProvider getIsPreDigestedTests
4646
*/
47-
public function testIsPreDigested(string $logicalPath, bool $expectedIsDigested): void
47+
public function testIsPreDigested(string $logicalPath, bool $expectedIsDigested)
4848
{
4949
$this->assertSame($expectedIsDigested, PipelinedAsset::isPreDigested($logicalPath));
5050
}

0 commit comments

Comments
 (0)