Throw exception before download query if entry is not valid

maelanleborgne · maelanleborgne · commit c28abee9abde · 2023-10-12T14:29:44.000+02:00
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/Resolver/JsDelivrEsmResolver.php b/src/Symfony/Component/AssetMapper/ImportMap/Resolver/JsDelivrEsmResolver.php
@@ -162,7 +162,7 @@ public function downloadPackages(array $importMapEntries, callable $progressCall
         foreach ($importMapEntries as $package => $entry) {
             $pattern = ImportMapType::CSS === $entry->type ? $this->distUrlCssPattern : $this->distUrlPattern;
             if (null === $entry->packageName || null === $entry->version || null === $entry->filePath) {
-                throw new RuntimeException(sprintf('The package %s cannot be downloaded. "packageName", "version" or "filePath" must be defined.', $entry->importName));
+                throw new RuntimeException(sprintf('The package "%s" cannot be downloaded. "packageName", "version" or "filePath" must be defined.', $entry->importName));
             }
             $url = sprintf($pattern, $entry->packageName, $entry->version, $entry->filePath);
 

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public function downloadPackages(array $importMapEntries, callable $progressCall`
`162`	`162`	`foreach ($importMapEntries as $package => $entry) {`
`163`	`163`	`$pattern = ImportMapType::CSS === $entry->type ? $this->distUrlCssPattern : $this->distUrlPattern;`
`164`	`164`	`if (null === $entry->packageName \|\| null === $entry->version \|\| null === $entry->filePath) {`
`165`		`- throw new RuntimeException(sprintf('The package %s cannot be downloaded. "packageName", "version" or "filePath" must be defined.', $entry->importName));`
	`165`	`+ throw new RuntimeException(sprintf('The package "%s" cannot be downloaded. "packageName", "version" or "filePath" must be defined.', $entry->importName));`
`166`	`166`	`}`
`167`	`167`	`$url = sprintf($pattern, $entry->packageName, $entry->version, $entry->filePath);`
`168`	`168`