Skip to content

Commit c6fe3c0

Browse files
committed
minor #12552 [FrameworkBundle] removed unneeded check (xabbuh)
This PR was merged into the 2.6 branch. Discussion ---------- [FrameworkBundle] removed unneeded check | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | It is already checked in the `isEnabled()` method of the parent `ServerCommand` class if the current PHP build is HHVM and the `server:start` command is never enabled then. Thus, it's not needed to check for HHVM on every command execution. This was pointed out by @stof in #12489 for the `server:run` command. Commits ------- ce2adfa removed unneeded check
2 parents 1ef9cf6 + ce2adfa commit c6fe3c0

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/Symfony/Bundle/FrameworkBundle/Command/ServerStartCommand.php

-5
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,6 @@ protected function configure()
7171
*/
7272
protected function execute(InputInterface $input, OutputInterface $output)
7373
{
74-
if (defined('HHVM_VERSION')) {
75-
$output->writeln('<error>This command is not supported on HHVM.</error>');
76-
77-
return 1;
78-
}
7974
if (!extension_loaded('pcntl')) {
8075
$output->writeln('<error>This command needs the pcntl extension to run.</error>');
8176
$output->writeln('You can either install it or use the <info>server:run</info> command instead to run the built-in web server.');

0 commit comments

Comments
 (0)