Implement PR suggestions

ostrolucky · ostrolucky · commit c7e01f48b9a9 · 2018-06-22T14:26:41.000+02:00
diff --git a/UPGRADE-4.2.md b/UPGRADE-4.2.md
@@ -10,7 +10,7 @@ Form
 ----
 
  * Deprecated calling `FormRenderer::searchAndRenderBlock` for fields which were already rendered. 
-   Instead of expecting such calls to return empty string, check if the field has already been rendered.
+   Instead of expecting such calls to return empty strings, check if the field has already been rendered.
  
    Before:
    ```twig
@@ -21,10 +21,8 @@ Form
    
    After:
    ```twig
-   {% for field in fieldsWithPotentialDuplicates %}
-     {% if not field.rendered %}
+   {% for field in fieldsWithPotentialDuplicates if not field.rendered %}
       {{ form_widget(field) }}
-     {% endif %}
    {% endfor %}
    ```
 Security
diff --git a/src/Symfony/Component/Form/FormRenderer.php b/src/Symfony/Component/Form/FormRenderer.php
@@ -133,7 +133,7 @@ public function searchAndRenderBlock(FormView $view, $blockNameSuffix, array $va
 
         if ($renderOnlyOnce && $view->isRendered()) {
             // This is not allowed, because it would result in rendering same IDs multiple times, which is not valid.
-            @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before. Trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.', $blockNameSuffix, $view->vars['name']), E_USER_DEPRECATED);
+            @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before, trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.', $blockNameSuffix, $view->vars['name']), E_USER_DEPRECATED);
             // throw new BadMethodCallException(sprintf('Field "%s" has already been rendered. Save result of previous  render call to variable and output that instead.', $view->vars['name']));
             return '';
         }

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ public function searchAndRenderBlock(FormView $view, $blockNameSuffix, array $va`
`133`	`133`
`134`	`134`	`if ($renderOnlyOnce && $view->isRendered()) {`
`135`	`135`	`// This is not allowed, because it would result in rendering same IDs multiple times, which is not valid.`
`136`		`- @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before. Trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.', $blockNameSuffix, $view->vars['name']), E_USER_DEPRECATED);`
	`136`	`+ @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before, trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.', $blockNameSuffix, $view->vars['name']), E_USER_DEPRECATED);`
`137`	`137`	`// throw new BadMethodCallException(sprintf('Field "%s" has already been rendered. Save result of previous render call to variable and output that instead.', $view->vars['name']));`
`138`	`138`	`return '';`
`139`	`139`	`}`