Add and modify tests for custom RememberMeDetails support

Patrick Elshof · Patrick Elshof · commit c8c3297dc938 · 2022-06-06T10:28:23.000+02:00
diff --git a/src/Symfony/Component/Security/Http/Tests/Authenticator/RememberMeAuthenticatorTest.php b/src/Symfony/Component/Security/Http/Tests/Authenticator/RememberMeAuthenticatorTest.php
@@ -31,7 +31,11 @@ class RememberMeAuthenticatorTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->rememberMeHandler = $this->createMock(RememberMeHandlerInterface::class);
+        $this->rememberMeHandler = $this->getMockBuilder(RememberMeHandlerInterface::class)
+            ->onlyMethods(get_class_methods(RememberMeHandlerInterface::class))
+            ->addMethods(['getRememberMeDetails', 'getUserIdentifierForCookie'])
+            ->getMock();
+
         $this->tokenStorage = new TokenStorage();
         $this->authenticator = new RememberMeAuthenticator($this->rememberMeHandler, 's3cr3t', $this->tokenStorage, '_remember_me_cookie');
     }
@@ -67,6 +71,15 @@ public function testAuthenticate()
     {
         $rememberMeDetails = new RememberMeDetails(InMemoryUser::class, 'wouter', 1, 'secret');
         $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => $rememberMeDetails->toString()]);
+
+        $this->rememberMeHandler->expects($this->once())->method('getRememberMeDetails')
+            ->with($rememberMeDetails->toString())
+            ->willReturn($rememberMeDetails);
+
+        $this->rememberMeHandler->expects($this->once())->method('getUserIdentifierForCookie')
+            ->with($rememberMeDetails)
+            ->willReturn('wouter');
+
         $passport = $this->authenticator->authenticate($request);
 
         $this->rememberMeHandler->expects($this->once())->method('consumeRememberMeCookie')->with($this->callback(function ($arg) use ($rememberMeDetails) {
@@ -86,7 +99,40 @@ public function testAuthenticateWithoutOldToken()
     {
         $this->expectException(AuthenticationException::class);
 
-        $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => base64_encode('foo:bar')]);
+        $encodedData = base64_encode('foo:bar');
+        $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => $encodedData]);
+
+        $this->rememberMeHandler->expects($this->once())->method('getRememberMeDetails')->with($encodedData)->willThrowException(new AuthenticationException());
         $this->authenticator->authenticate($request);
     }
+
+    public function testAuthenticateDeprecatedCodePath()
+    {
+        $mock = $this->getMockBuilder(RememberMeHandlerInterface::class)
+            ->getMock();
+
+        $rememberMeDetails = new RememberMeDetails(InMemoryUser::class, 'wouter', 1, 'secret');
+        $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => $rememberMeDetails->toString()]);
+
+        $authenticator = new RememberMeAuthenticator($mock, 's3cr3t', $this->tokenStorage, '_remember_me_cookie');
+        $passport = $authenticator->authenticate($request);
+
+        $mock->expects($this->once())->method('consumeRememberMeCookie')->with($this->callback(function ($arg) use ($rememberMeDetails) {
+            return $rememberMeDetails == $arg;
+        }));
+        $passport->getUser(); // trigger the user loader
+    }
+
+    public function testAuthenticateWithoutOldTokenDeprecatedCodePath()
+    {
+        $mock = $this->getMockBuilder(RememberMeHandlerInterface::class)
+            ->getMock();
+
+        $this->expectException(AuthenticationException::class);
+
+        $request = Request::create('/', 'GET', [], ['_remember_me_cookie' => base64_encode('foo:bar')]);
+
+        $authenticator = new RememberMeAuthenticator($mock, 's3cr3t', $this->tokenStorage, '_remember_me_cookie');
+        $authenticator->authenticate($request);
+    }
 }
diff --git a/src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentRememberMeHandlerTest.php b/src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentRememberMeHandlerTest.php
@@ -130,4 +130,16 @@ public function testConsumeRememberMeCookieExpired()
 
         $this->handler->consumeRememberMeCookie(new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'series1:tokenvalue'));
     }
+
+    public function testGetUserIdentifierForCookie()
+    {
+        $this->assertEquals('wouter', $this->handler->getUserIdentifierForCookie(new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'signature')));
+    }
+
+    public function testGetRememberMeDetails()
+    {
+        $details = new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'signature');
+
+        $this->assertEquals($details, $this->handler->getRememberMeDetails($details->toString()));
+    }
 }
diff --git a/src/Symfony/Component/Security/Http/Tests/RememberMe/SignatureRememberMeHandlerTest.php b/src/Symfony/Component/Security/Http/Tests/RememberMe/SignatureRememberMeHandlerTest.php
@@ -122,4 +122,16 @@ public function testConsumeRememberMeCookieExpired()
 
         $this->handler->consumeRememberMeCookie(new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'signature'));
     }
+
+    public function testGetUserIdentifierForCookie()
+    {
+        $this->assertEquals('wouter', $this->handler->getUserIdentifierForCookie(new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'signature')));
+    }
+
+    public function testGetRememberMeDetails()
+    {
+        $details = new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'signature');
+
+        $this->assertEquals($details, $this->handler->getRememberMeDetails($details->toString()));
+    }
 }
