Add a test to check that the translation domain is passed on

mpdude · mpdude · commit c8f94d4186b7 · 2025-03-11T18:59:11.000+01:00
diff --git a/src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php b/src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php
@@ -17,6 +17,7 @@
 use PHPUnit\Framework\Constraint\IsNull;
 use PHPUnit\Framework\Constraint\LogicalOr;
 use PHPUnit\Framework\ExpectationFailedException;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Constraints\GroupSequence;
@@ -61,6 +62,8 @@ abstract class ConstraintValidatorTestCase extends TestCase
     protected Constraint $constraint;
     protected ?string $defaultTimezone = null;
 
+    private TranslatorInterface&MockObject $translator;
+
     private string $defaultLocale;
     private array $expectedViolations;
     private int $call;
@@ -122,14 +125,14 @@ protected function restoreDefaultTimezone()
 
     protected function createContext()
     {
-        $translator = $this->createMock(TranslatorInterface::class);
-        $translator->expects($this->any())->method('trans')->willReturnArgument(0);
+        $this->translator = $this->createMock(TranslatorInterface::class);
+        $this->translator->expects($this->any())->method('trans')->willReturnArgument(0);
         $validator = $this->createMock(ValidatorInterface::class);
         $validator->expects($this->any())
             ->method('validate')
             ->willReturnCallback(fn () => $this->expectedViolations[$this->call++] ?? new ConstraintViolationList());
 
-        $context = new ExecutionContext($validator, $this->root, $translator);
+        $context = new ExecutionContext($validator, $this->root, $this->translator);
         $context->setGroup($this->group);
         $context->setNode($this->value, $this->object, $this->metadata, $this->propertyPath);
         $context->setConstraint($this->constraint);
@@ -277,6 +280,14 @@ protected function expectViolationsAt(int $i, mixed $value, Constraint $constrai
         return $context->getViolations();
     }
 
+    protected function expectTranslationDomain(string $translationDomain)
+    {
+        $this->translator
+            ->expects($this->atLeastOnce())
+            ->method('trans')
+            ->with($this->anything(), $this->anything(), $translationDomain, $this->anything());
+    }
+
     protected function assertNoViolation()
     {
         $this->assertSame(0, $violationsCount = \count($this->context->getViolations()), \sprintf('0 violation expected. Got %u.', $violationsCount));
@@ -301,6 +312,7 @@ final class ConstraintViolationAssertion
     private ?int $plural = null;
     private ?string $code = null;
     private mixed $cause = null;
+    private ?string $translationDomain = null;
 
     /**
      * @param ConstraintViolationAssertion[] $assertions
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/NotBlankValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/NotBlankValidatorTest.php
@@ -55,6 +55,15 @@ public function testNullIsInvalid()
             ->assertRaised();
     }
 
+    public function testTranslationDomain()
+    {
+        $constraint = new NotBlank(translationDomain: 'my_domain');
+
+        $this->expectTranslationDomain('my_domain');
+
+        $this->validator->validate(null, $constraint);
+    }
+
     public function testBlankIsInvalid()
     {
         $constraint = new NotBlank(message: 'myMessage');
