[ExpressionLanguage] throw exception when parameters contain expressions

aitboudad · aitboudad · commit ca123bc7afe7 · 2013-12-04T21:23:04.000Z
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -980,6 +980,8 @@ private function exportParameters($parameters, $path = '', $indent = 12)
                 throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain service definitions. Definition for "%s" found in "%s".', $value->getClass(), $path.'/'.$key));
             } elseif ($value instanceof Reference) {
                 throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain references to other services (reference to service "%s" found in "%s").', $value, $path.'/'.$key));
+            } elseif ($value instanceof Expression) {
+                throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain expressions. Expression "%s" found in "%s".', $value, $path.'/'.$key));
             } else {
                 $value = var_export($value, true);
             }

Original file line number	Diff line number	Diff line change
`@@ -980,6 +980,8 @@ private function exportParameters($parameters, $path = '', $indent = 12)`
`980`	`980`	`throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain service definitions. Definition for "%s" found in "%s".', $value->getClass(), $path.'/'.$key));`
`981`	`981`	`} elseif ($value instanceof Reference) {`
`982`	`982`	`throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain references to other services (reference to service "%s" found in "%s").', $value, $path.'/'.$key));`
	`983`	`+ } elseif ($value instanceof Expression) {`
	`984`	`+ throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain expressions. Expression "%s" found in "%s".', $value, $path.'/'.$key));`
`983`	`985`	`} else {`
`984`	`986`	`$value = var_export($value, true);`
`985`	`987`	`}`