minor #60284 Unnecessary cast, return, semicolon and comma (wkania)

chalasr · chalasr · commit ca8a99ef4306 · 2025-04-27T17:22:02.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- Unnecessary cast, return, semicolon and comma | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT isEqualTo always return null. Commits ------- 23cc764 Unnecessary cast, return, semicolon and comma
diff --git a/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php b/src/Symfony/Bridge/Doctrine/Tests/ArgumentResolver/EntityValueResolverTest.php
@@ -153,7 +153,7 @@ public function testResolveWithArrayIdNullValue()
         $request = new Request();
         $request->attributes->set('nullValue', null);
 
-        $argument = $this->createArgument(entity: new MapEntity(id: ['nullValue']), isNullable: true,);
+        $argument = $this->createArgument(entity: new MapEntity(id: ['nullValue']), isNullable: true);
 
         $this->assertSame([null], $resolver->resolve($request, $argument));
     }
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php
@@ -239,7 +239,7 @@ public function testReverseTransformFromDifferentLocale()
     {
         if (version_compare(Intl::getIcuVersion(), '71.1', '>')) {
             $this->markTestSkipped('ICU version 71.1 or lower is required.');
-        };
+        }
 
         \Locale::setDefault('en_US');
 
diff --git a/src/Symfony/Component/Notifier/Tests/Channel/AbstractChannelTest.php b/src/Symfony/Component/Notifier/Tests/Channel/AbstractChannelTest.php
@@ -34,7 +34,6 @@ class DummyChannel extends AbstractChannel
 {
     public function notify(Notification $notification, RecipientInterface $recipient, ?string $transportName = null): void
     {
-        return;
     }
 
     public function supports(Notification $notification, RecipientInterface $recipient): bool
diff --git a/src/Symfony/Component/Security/Http/Firewall/ContextListener.php b/src/Symfony/Component/Security/Http/Firewall/ContextListener.php
@@ -290,7 +290,7 @@ private static function hasUserChanged(UserInterface $originalUser, TokenInterfa
         $refreshedUser = $refreshedToken->getUser();
 
         if ($originalUser instanceof EquatableInterface) {
-            return !(bool) $originalUser->isEqualTo($refreshedUser);
+            return !$originalUser->isEqualTo($refreshedUser);
         }
 
         if ($originalUser instanceof PasswordAuthenticatedUserInterface || $refreshedUser instanceof PasswordAuthenticatedUserInterface) {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public function testResolveWithArrayIdNullValue()`
`153`	`153`	`$request = new Request();`
`154`	`154`	`$request->attributes->set('nullValue', null);`
`155`	`155`
`156`		`- $argument = $this->createArgument(entity: new MapEntity(id: ['nullValue']), isNullable: true,);`
	`156`	`+ $argument = $this->createArgument(entity: new MapEntity(id: ['nullValue']), isNullable: true);`
`157`	`157`
`158`	`158`	`$this->assertSame([null], $resolver->resolve($request, $argument));`
`159`	`159`	`}`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ public function testReverseTransformFromDifferentLocale()`
`239`	`239`	`{`
`240`	`240`	`if (version_compare(Intl::getIcuVersion(), '71.1', '>')) {`
`241`	`241`	`$this->markTestSkipped('ICU version 71.1 or lower is required.');`
`242`		`- };`
	`242`	`+ }`
`243`	`243`
`244`	`244`	`\Locale::setDefault('en_US');`
`245`	`245`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ class DummyChannel extends AbstractChannel`
`34`	`34`	`{`
`35`	`35`	`public function notify(Notification $notification, RecipientInterface $recipient, ?string $transportName = null): void`
`36`	`36`	`{`
`37`		`- return;`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`public function supports(Notification $notification, RecipientInterface $recipient): bool`
Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ private static function hasUserChanged(UserInterface $originalUser, TokenInterfa`
`290`	`290`	`$refreshedUser = $refreshedToken->getUser();`
`291`	`291`
`292`	`292`	`if ($originalUser instanceof EquatableInterface) {`
`293`		`- return !(bool) $originalUser->isEqualTo($refreshedUser);`
	`293`	`+ return !$originalUser->isEqualTo($refreshedUser);`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`if ($originalUser instanceof PasswordAuthenticatedUserInterface \|\| $refreshedUser instanceof PasswordAuthenticatedUserInterface) {`