generate conflict-free variable names

xabbuh · xabbuh · commit ca8bb620aecc · 2024-12-02T10:16:41.000+01:00
diff --git a/src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php b/src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php
@@ -21,7 +21,8 @@
 use Twig\Node\Expression\ConstantExpression;
 use Twig\Node\Expression\FilterExpression;
 use Twig\Node\Expression\NameExpression;
-use Twig\Node\Expression\Variable\LocalVariable;
+use Twig\Node\Expression\Variable\AssignContextVariable;
+use Twig\Node\Expression\Variable\ContextVariable;
 use Twig\Node\ModuleNode;
 use Twig\Node\Node;
 use Twig\Node\Nodes;
@@ -33,8 +34,10 @@
  */
 final class TranslationDefaultDomainNodeVisitor implements NodeVisitorInterface
 {
+    private const INTERNAL_VAR_NAME = '__internal_trans_default_domain';
+
     private Scope $scope;
-    private int $nestingLevel = 0;
+    private int $nameCounter = 0;
 
     public function __construct()
     {
@@ -48,24 +51,21 @@ public function enterNode(Node $node, Environment $env): Node
         }
 
         if ($node instanceof TransDefaultDomainNode) {
-            ++$this->nestingLevel;
-
             if ($node->getNode('expr') instanceof ConstantExpression) {
                 $this->scope->set('domain', $node->getNode('expr'));
 
                 return $node;
             }
 
             if (class_exists(Nodes::class)) {
-                $name = new LocalVariable(null, $node->getTemplateLine());
-                $this->scope->set('domain', $name);
+                $name = new AssignContextVariable(self::INTERNAL_VAR_NAME.(++$this->nameCounter), $node->getTemplateLine());
+                $this->scope->set('domain', new ContextVariable(self::INTERNAL_VAR_NAME.(++$this->nameCounter), $node->getTemplateLine()));
 
                 return new SetNode(false, new Nodes([$name]), new Nodes([$node->getNode('expr')]), $node->getTemplateLine());
             }
 
-            $var = '__internal_trans_default_domain_'.$this->nestingLevel;
-            $name = new AssignNameExpression($var, $node->getTemplateLine());
-            $this->scope->set('domain', new NameExpression($var, $node->getTemplateLine()));
+            $name = new AssignNameExpression(self::INTERNAL_VAR_NAME.(++$this->nameCounter), $node->getTemplateLine());
+            $this->scope->set('domain', new NameExpression(self::INTERNAL_VAR_NAME.(++$this->nameCounter), $node->getTemplateLine()));
 
             return new SetNode(false, new Node([$name]), new Node([$node->getNode('expr')]), $node->getTemplateLine());
         }
@@ -105,8 +105,6 @@ public function enterNode(Node $node, Environment $env): Node
     public function leaveNode(Node $node, Environment $env): ?Node
     {
         if ($node instanceof TransDefaultDomainNode) {
-            --$this->nestingLevel;
-
             return null;
         }
 
