Skip to content

Commit cadcc57

Browse files
minor #60649 [VarDumper] Fix tests on PHP 8.4 (nicolas-grekas)
This PR was merged into the 7.3 branch. Discussion ---------- [VarDumper] Fix tests on PHP 8.4 | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 2070c33 [VarDumper] Fix tests on PHP 8.4
2 parents 3fe1681 + 2070c33 commit cadcc57

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/Symfony/Component/VarDumper/Tests/Caster/ResourceCasterTest.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,11 @@ public function testCastDbaPriorToPhp84()
6969
}
7070

7171
/**
72-
* @requires PHP 8.4
72+
* @requires PHP 8.4.2
73+
* @requires extension dba
7374
*/
7475
public function testCastDba()
7576
{
76-
if (\PHP_VERSION_ID < 80402) {
77-
$this->markTestSkipped('The test cannot be run on PHP 8.4.0 and PHP 8.4.1, see https://github.com/php/php-src/issues/16990');
78-
}
79-
8077
$dba = dba_open(sys_get_temp_dir().'/test.db', 'c');
8178

8279
$this->assertDumpMatchesFormat(
@@ -89,6 +86,7 @@ public function testCastDba()
8986

9087
/**
9188
* @requires PHP 8.4
89+
* @requires extension dba
9290
*/
9391
public function testCastDbaOnBuggyPhp84()
9492
{

0 commit comments

Comments
 (0)