[PropertyInfo] Fix code review

alyamovsky · alyamovsky · commit ceafe5d710cd · 2024-07-13T01:31:36.000+02:00
diff --git a/src/Symfony/Component/PropertyInfo/PropertyAttributesExtractorInterface.php b/src/Symfony/Component/PropertyInfo/PropertyAttributesExtractorInterface.php
@@ -21,7 +21,9 @@ interface PropertyAttributesExtractorInterface
      *
      * Returns an array of attributes, each attribute is an associative array with the following keys:
      * - name: The fully-qualified class name of the attribute
-     * - arguments: An associative array of attribute arguments
+     * - arguments: An associative array of attribute arguments if present
+     *
+     * @return array<int, array{name: string, arguments: array<array-key, mixed>}>|null
      */
     public function getAttributes(string $class, string $property, array $context = []): ?array;
 }
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php
@@ -501,14 +501,14 @@ public static function getInitializableProperties(): array
     }
 
     /**
-     * @dataProvider getAttributes
+     * @dataProvider attributesProvider
      */
     public function testGetAttributes(string $class, string $property, ?array $expected)
     {
         $this->assertSame($expected, $this->extractor->getAttributes($class, $property));
     }
 
-    public static function getAttributes(): array
+    public static function attributesProvider(): array
     {
         return [
             [
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/DummyAttribute.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/DummyAttribute.php
@@ -9,7 +9,6 @@ public function __construct(
         public string $type,
         public string $name,
         public int $version,
-    )
-    {
+    ) {
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,9 @@ interface PropertyAttributesExtractorInterface`
`21`	`21`	`*`
`22`	`22`	`* Returns an array of attributes, each attribute is an associative array with the following keys:`
`23`	`23`	`* - name: The fully-qualified class name of the attribute`
`24`		`- * - arguments: An associative array of attribute arguments`
	`24`	`+ * - arguments: An associative array of attribute arguments if present`
	`25`	`+ *`
	`26`	`+ * @return array<int, array{name: string, arguments: array<array-key, mixed>}>\|null`
`25`	`27`	`*/`
`26`	`28`	`public function getAttributes(string $class, string $property, array $context = []): ?array;`
`27`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -501,14 +501,14 @@ public static function getInitializableProperties(): array`
`501`	`501`	`}`
`502`	`502`
`503`	`503`	`/**`
`504`		`- * @dataProvider getAttributes`
	`504`	`+ * @dataProvider attributesProvider`
`505`	`505`	`*/`
`506`	`506`	`public function testGetAttributes(string $class, string $property, ?array $expected)`
`507`	`507`	`{`
`508`	`508`	`$this->assertSame($expected, $this->extractor->getAttributes($class, $property));`
`509`	`509`	`}`
`510`	`510`
`511`		`- public static function getAttributes(): array`
	`511`	`+ public static function attributesProvider(): array`
`512`	`512`	`{`
`513`	`513`	`return [`
`514`	`514`	`[`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ public function __construct(`
`9`	`9`	`public string $type,`
`10`	`10`	`public string $name,`
`11`	`11`	`public int $version,`
`12`		`- )`
`13`		`- {`
	`12`	`+ ) {`
`14`	`13`	`}`
`15`	`14`	`}`