[Security] [Guard] Added type-hints to AuthenticatorInterface

thomasbisignani · thomasbisignani · commit d02bbdea9ac2 · 2019-06-28T14:11:48.000+02:00
diff --git a/src/Symfony/Component/Security/Guard/AbstractGuardAuthenticator.php b/src/Symfony/Component/Security/Guard/AbstractGuardAuthenticator.php
@@ -30,7 +30,7 @@ abstract class AbstractGuardAuthenticator implements AuthenticatorInterface
      *
      * @return PostAuthenticationGuardToken
      */
-    public function createAuthenticatedToken(UserInterface $user, $providerKey)
+    public function createAuthenticatedToken(UserInterface $user, string $providerKey)
     {
         return new PostAuthenticationGuardToken(
             $user,
diff --git a/src/Symfony/Component/Security/Guard/AuthenticatorInterface.php b/src/Symfony/Component/Security/Guard/AuthenticatorInterface.php
@@ -117,7 +117,7 @@ public function checkCredentials($credentials, UserInterface $user);
      *
      * @return GuardTokenInterface
      */
-    public function createAuthenticatedToken(UserInterface $user, $providerKey);
+    public function createAuthenticatedToken(UserInterface $user, string $providerKey);
 
     /**
      * Called when authentication executed, but failed (e.g. wrong username password).
@@ -150,7 +150,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
      *
      * @return Response|null
      */
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey);
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey);
 
     /**
      * Does this method support remember me cookies?
diff --git a/src/Symfony/Component/Security/Guard/Tests/Authenticator/FormLoginAuthenticatorTest.php b/src/Symfony/Component/Security/Guard/Tests/Authenticator/FormLoginAuthenticatorTest.php
@@ -103,7 +103,7 @@ public function supports(Request $request)
         return true;
     }
 
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey)
     {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ abstract class AbstractGuardAuthenticator implements AuthenticatorInterface`
`30`	`30`	`*`
`31`	`31`	`* @return PostAuthenticationGuardToken`
`32`	`32`	`*/`
`33`		`- public function createAuthenticatedToken(UserInterface $user, $providerKey)`
	`33`	`+ public function createAuthenticatedToken(UserInterface $user, string $providerKey)`
`34`	`34`	`{`
`35`	`35`	`return new PostAuthenticationGuardToken(`
`36`	`36`	`$user,`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function supports(Request $request)`
`103`	`103`	`return true;`
`104`	`104`	`}`
`105`	`105`
`106`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)`
	`106`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey)`
`107`	`107`	`{`
`108`	`108`	`}`
`109`	`109`