minor #32404 [Validator] remove tests for legacy behaviour (xabbuh)

ogizanagi · ogizanagi · commit d17b33346122 · 2019-07-06T16:50:07.000+02:00
This PR was merged into the 5.0-dev branch. Discussion ---------- [Validator] remove tests for legacy behaviour | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- d6d4aba remove tests for legacy behaviour
diff --git a/src/Symfony/Component/Validator/ConstraintViolation.php b/src/Symfony/Component/Validator/ConstraintViolation.php
@@ -84,7 +84,7 @@ public function __toString()
             $class .= '.';
         }
 
-        if ('' !== $code = (string) $this->code) {
+        if (null !== $this->code && '' !== $code = $this->code) {
             $code = ' (code '.$code.')';
         }
 
diff --git a/src/Symfony/Component/Validator/Tests/ConstraintViolationTest.php b/src/Symfony/Component/Validator/Tests/ConstraintViolationTest.php
@@ -108,20 +108,4 @@ public function testToStringOmitsEmptyCodes()
 
         $this->assertSame($expected, (string) $violation);
     }
-
-    public function testNonStringCode()
-    {
-        $violation = new ConstraintViolation(
-            '42 cannot be used here',
-            'this is the message template',
-            [],
-            ['some_value' => 42],
-            'some_value',
-            null,
-            null,
-            42
-        );
-
-        self::assertSame('42', $violation->getCode());
-    }
 }
diff --git a/src/Symfony/Component/Validator/Tests/Violation/ConstraintViolationBuilderTest.php b/src/Symfony/Component/Validator/Tests/Violation/ConstraintViolationBuilderTest.php

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public function __toString()`
`84`	`84`	`$class .= '.';`
`85`	`85`	`}`
`86`	`86`
`87`		`- if ('' !== $code = (string) $this->code) {`
	`87`	`+ if (null !== $this->code && '' !== $code = $this->code) {`
`88`	`88`	`$code = ' (code '.$code.')';`
`89`	`89`	`}`
`90`	`90`