Prefer using null coalesce over empty condition check

Jan Pintr · Jan Pintr · commit d966e61f41c8 · 2025-08-03T14:10:11.000+02:00
diff --git a/src/Symfony/Component/Scheduler/DependencyInjection/AddScheduleMessengerPass.php b/src/Symfony/Component/Scheduler/DependencyInjection/AddScheduleMessengerPass.php
@@ -60,7 +60,7 @@ public function process(ContainerBuilder $container): void
                     $attribute = ($container->getReflectionClass($serviceDefinition->getClass())->getAttributes(AsCommand::class)[0] ?? null)?->newInstance();
                     $commandName = $attribute?->name ?? $serviceDefinition->getClass()::getDefaultName();
 
-                    $message = new Definition(RunCommandMessage::class, [$commandName.(!empty($tagAttributes['arguments']) ? " {$tagAttributes['arguments']}" : '')]);
+                    $message = new Definition(RunCommandMessage::class, [$commandName.(($tagAttributes['arguments'] ?? null) ? " {$tagAttributes['arguments']}" : '')]);
                 } else {
                     $message = new Definition(ServiceCallMessage::class, [$serviceId, $tagAttributes['method'] ?? '__invoke', (array) ($tagAttributes['arguments'] ?? [])]);
                 }
diff --git a/src/Symfony/Component/Scheduler/Tests/DependencyInjection/AddScheduleMessengerPassTest.php b/src/Symfony/Component/Scheduler/Tests/DependencyInjection/AddScheduleMessengerPassTest.php
@@ -50,6 +50,7 @@ public static function processSchedulerTaskCommandProvider(): iterable
     {
         yield 'no arguments' => [['trigger' => 'every', 'frequency' => '1 hour'], 'schedulable'];
         yield 'null arguments' => [['trigger' => 'every', 'frequency' => '1 hour', 'arguments' => null], 'schedulable'];
+        yield 'empty arguments' => [['trigger' => 'every', 'frequency' => '1 hour', 'arguments' => ''], 'schedulable'];
         yield 'test argument' => [['trigger' => 'every', 'frequency' => '1 hour', 'arguments' => 'test'], 'schedulable test'];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function process(ContainerBuilder $container): void`
`60`	`60`	`$attribute = ($container->getReflectionClass($serviceDefinition->getClass())->getAttributes(AsCommand::class)[0] ?? null)?->newInstance();`
`61`	`61`	`$commandName = $attribute?->name ?? $serviceDefinition->getClass()::getDefaultName();`
`62`	`62`
`63`		`- $message = new Definition(RunCommandMessage::class, [$commandName.(!empty($tagAttributes['arguments']) ? " {$tagAttributes['arguments']}" : '')]);`
	`63`	`+ $message = new Definition(RunCommandMessage::class, [$commandName.(($tagAttributes['arguments'] ?? null) ? " {$tagAttributes['arguments']}" : '')]);`
`64`	`64`	`} else {`
`65`	`65`	`$message = new Definition(ServiceCallMessage::class, [$serviceId, $tagAttributes['method'] ?? '__invoke', (array) ($tagAttributes['arguments'] ?? [])]);`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ public static function processSchedulerTaskCommandProvider(): iterable`
`50`	`50`	`{`
`51`	`51`	`yield 'no arguments' => [['trigger' => 'every', 'frequency' => '1 hour'], 'schedulable'];`
`52`	`52`	`yield 'null arguments' => [['trigger' => 'every', 'frequency' => '1 hour', 'arguments' => null], 'schedulable'];`
	`53`	`+ yield 'empty arguments' => [['trigger' => 'every', 'frequency' => '1 hour', 'arguments' => ''], 'schedulable'];`
`53`	`54`	`yield 'test argument' => [['trigger' => 'every', 'frequency' => '1 hour', 'arguments' => 'test'], 'schedulable test'];`
`54`	`55`	`}`
`55`	`56`	`}`