bug #50577 [HttpClient] Remove final keyword on AsyncResponse (lyrixx)

nicolas-grekas · nicolas-grekas · commit d9a89027e74b · 2023-06-09T11:05:58.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [HttpClient] Remove final keyword on `AsyncResponse` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | kind of | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | In symfony < 6.3, it was possible to override HTTP response headers. See this [blog post](https://jolicode.com/blog/aggressive-caching-with-symfony-http-client) for a use case With Symfony 6.3, this is not possible anymore. I created a reproducer here: https://github.com/lyrixx/test/tree/http-cache-pp And `@nicolas`-grekas came with another solution: lyrixx/test#11 So here we go! Commits ------- fbd6d18 [HttpClient] Remove final keyword on AsyncResponse
diff --git a/src/Symfony/Component/HttpClient/Response/AsyncResponse.php b/src/Symfony/Component/HttpClient/Response/AsyncResponse.php
@@ -27,7 +27,7 @@
  *
  * @author Nicolas Grekas <p@tchwork.com>
  */
-final class AsyncResponse implements ResponseInterface, StreamableInterface
+class AsyncResponse implements ResponseInterface, StreamableInterface
 {
     use CommonResponseTrait;
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`*`
`28`	`28`	`* @author Nicolas Grekas <p@tchwork.com>`
`29`	`29`	`*/`
`30`		`-final class AsyncResponse implements ResponseInterface, StreamableInterface`
	`30`	`+class AsyncResponse implements ResponseInterface, StreamableInterface`
`31`	`31`	`{`
`32`	`32`	`use CommonResponseTrait;`
`33`	`33`