bug #60303 [Validator] use deprecation catching error handler only when parsing Twig templates (xabbuh)

fabpot · fabpot · commit d9d3d6a74653 · 2025-05-02T10:34:03.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [Validator] use deprecation catching error handler only when parsing Twig templates | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT IMO an error handler catching deprecations should not step in when other code not related to the Twig templates triggers deprecations. I'd argue that we should check our lint commands as well instead. Commits ------- ea5767d use deprecation catching error handler only when parsing Twig templates
diff --git a/src/Symfony/Bridge/Twig/Validator/Constraints/TwigValidator.php b/src/Symfony/Bridge/Twig/Validator/Constraints/TwigValidator.php
@@ -45,26 +45,33 @@ public function validate(mixed $value, Constraint $constraint): void
 
         $value = (string) $value;
 
-        if (!$constraint->skipDeprecations) {
-            $prevErrorHandler = set_error_handler(static function ($level, $message, $file, $line) use (&$prevErrorHandler) {
-                if (\E_USER_DEPRECATED !== $level) {
-                    return $prevErrorHandler ? $prevErrorHandler($level, $message, $file, $line) : false;
-                }
-
-                $templateLine = 0;
-                if (preg_match('/ at line (\d+)[ .]/', $message, $matches)) {
-                    $templateLine = $matches[1];
-                }
-
-                throw new Error($message, $templateLine);
-            });
-        }
-
         $realLoader = $this->twig->getLoader();
         try {
             $temporaryLoader = new ArrayLoader([$value]);
             $this->twig->setLoader($temporaryLoader);
-            $this->twig->parse($this->twig->tokenize(new Source($value, '')));
+
+            if (!$constraint->skipDeprecations) {
+                $prevErrorHandler = set_error_handler(static function ($level, $message, $file, $line) use (&$prevErrorHandler) {
+                    if (\E_USER_DEPRECATED !== $level) {
+                        return $prevErrorHandler ? $prevErrorHandler($level, $message, $file, $line) : false;
+                    }
+
+                    $templateLine = 0;
+                    if (preg_match('/ at line (\d+)[ .]/', $message, $matches)) {
+                        $templateLine = $matches[1];
+                    }
+
+                    throw new Error($message, $templateLine);
+                });
+            }
+
+            try {
+                $this->twig->parse($this->twig->tokenize(new Source($value, '')));
+            } finally {
+                if (!$constraint->skipDeprecations) {
+                    restore_error_handler();
+                }
+            }
         } catch (Error $e) {
             $this->context->buildViolation($constraint->message)
                 ->setParameter('{{ error }}', $e->getMessage())
@@ -73,9 +80,6 @@ public function validate(mixed $value, Constraint $constraint): void
                 ->addViolation();
         } finally {
             $this->twig->setLoader($realLoader);
-            if (!$constraint->skipDeprecations) {
-                restore_error_handler();
-            }
         }
     }
 }
