minor #12537 [HttpFoundation] Make Request::get() more performant (KorvinSzanto, xabbuh)

fabpot · fabpot · commit da1c1c578b92 · 2014-11-21T17:05:55.000+01:00
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #12537). Discussion ---------- [HttpFoundation] Make Request::get() more performant | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This finishes the work started by @KorvinSzanto in #12369. Commits ------- 3039935 reformat code as suggested by @fabpot ad64223 Fix typo 4162713 Make `\Request::get` more performant.
diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -692,7 +692,19 @@ public static function getHttpMethodParameterOverride()
      */
     public function get($key, $default = null, $deep = false)
     {
-        return $this->query->get($key, $this->attributes->get($key, $this->request->get($key, $default, $deep), $deep), $deep);
+        if ($this !== $result = $this->query->get($key, $this, $deep)) {
+            return $result;
+        }
+
+        if ($this !== $result = $this->attributes->get($key, $this, $deep)) {
+            return $result;
+        }
+
+        if ($this !== $result = $this->request->get($key, $this, $deep)) {
+            return $result;
+        }
+
+        return $default;
     }
 
     /**
