Don't trigger deprecations twice

GuilhemN · GuilhemN · commit dd815e526a87 · 2016-08-25T16:02:17.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -186,6 +186,16 @@ class Response
         511 => 'Network Authentication Required',                             // RFC6585
     );
 
+    private static $deprecatedMethods = array('setDate', 'setExpires', 'setLastModified', 'getDate', 'getExpires', 'getLastModified');
+    private static $deprecationsTriggered = array(
+        __CLASS__ => true,
+        ApacheRequest::class => true,
+        BinaryFileResponse::class => true,
+        JsonResponse::class => true,
+        RedirectResponse::class => true,
+        StreamedResponse::class => true,
+    );
+
     /**
      * Constructor.
      *
@@ -204,11 +214,12 @@ public function __construct($content = '', $status = 200, $headers = array())
 
         // Deprecations
         $class = get_class($this);
-        if (__CLASS__ === $class || 0 === strpos($class, 'Symfony\\')) {
+        if (isset(self::$deprecationsTriggered[$class])) {
             return;
         }
 
-        foreach (array('setDate', 'setExpires', 'setLastModified', 'getDate', 'getExpires', 'getLastModified') as $method) {
+        self::$deprecationsTriggered[$class] = true;
+        foreach (self::$deprecatedMethods as $method) {
             $m = new \ReflectionMethod($this, $method);
             if (__CLASS__ !== $m->getDeclaringClass()->getName()) {
                 @trigger_error(sprintf('Extending %s::%s() is deprecated since version 3.2 and won\'t be supported anymore in 4.0 as it will be final.', __CLASS__, $method), E_USER_DEPRECATED);
diff --git a/src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php
@@ -863,6 +863,9 @@ public function testDeprecations()
     {
         ErrorAssert::assertDeprecationsAreTriggered(array(sprintf('Extending %s::setLastModified() is deprecated', Response::class), sprintf('Extending %s::getDate() is deprecated', Response::class)), function () {
             new ExtendedResponse();
+
+            // Deprecations should not be triggered twice
+            new ExtendedResponse();
         });
     }
 

Original file line number	Diff line number	Diff line change
`@@ -863,6 +863,9 @@ public function testDeprecations()`
`863`	`863`	`{`
`864`	`864`	`ErrorAssert::assertDeprecationsAreTriggered(array(sprintf('Extending %s::setLastModified() is deprecated', Response::class), sprintf('Extending %s::getDate() is deprecated', Response::class)), function () {`
`865`	`865`	`new ExtendedResponse();`
	`866`	`+`
	`867`	`+ // Deprecations should not be triggered twice`
	`868`	`+ new ExtendedResponse();`
`866`	`869`	`});`
`867`	`870`	`}`
`868`	`871`