Skip to content

Commit deb527d

Browse files
nicolas-grekasnicolas-grekas
committed
Merge branch '3.1'
* 3.1: [travis] fix after box updates Console: Fix indentation of Help: section of txt usage help [Intl] Update ICU data to 57.1 [Config] Improved test Added class existence check if is_subclass_of() fails in compiler passes
2 parents ccb684a + 0416b8a commit deb527d

File tree

878 files changed

+15086
-8467
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

878 files changed

+15086
-8467
lines changed

‎.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ before_install:
6363
- if [[ ! $skip && ! $PHP = hhvm* ]]; then echo extension = ldap.so >> $INI_FILE; fi
6464
- if [[ ! $skip && ! $PHP = hhvm* ]]; then echo extension = redis.so >> $INI_FILE; fi;
6565
- if [[ ! $skip && ! $PHP = hhvm* ]]; then phpenv config-rm xdebug.ini || echo "xdebug not available"; fi
66-
- if [[ ! $skip ]]; then composer self-update --stable; fi
67-
- if [[ ! $skip ]]; then cp .composer/* ~/.composer/; fi
66+
- if [[ ! $skip ]]; then [ -d ~/.composer ] || mkdir ~/.composer; cp .composer/* ~/.composer/; fi
6867
- if [[ ! $skip ]]; then ./phpunit install; fi
6968
- if [[ ! $skip ]]; then export PHPUNIT=$(readlink -f ./phpunit); fi
7069
- if [[ ! $skip ]]; then ldapadd -h localhost:3389 -D cn=admin,dc=symfony,dc=com -w symfony -f src/Symfony/Component/Ldap/Tests/Fixtures/data/base.ldif; fi

‎src/Symfony/Component/Config/Tests/Definition/ArrayNodeTest.php

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,4 +173,41 @@ public function getPreNormalizedNormalizedOrderedData()
173173
),
174174
);
175175
}
176+
177+
/**
178+
* @expectedException \InvalidArgumentException
179+
* @expectedExceptionMessage Child nodes must be named.
180+
*/
181+
public function testAddChildEmptyName()
182+
{
183+
$node = new ArrayNode('root');
184+
185+
$childNode = new ArrayNode('');
186+
$node->addChild($childNode);
187+
}
188+
189+
/**
190+
* @expectedException \InvalidArgumentException
191+
* @expectedExceptionMessage A child node named "foo" already exists.
192+
*/
193+
public function testAddChildNameAlreadyExists()
194+
{
195+
$node = new ArrayNode('root');
196+
197+
$childNode = new ArrayNode('foo');
198+
$node->addChild($childNode);
199+
200+
$childNodeWithSameName = new ArrayNode('foo');
201+
$node->addChild($childNodeWithSameName);
202+
}
203+
204+
/**
205+
* @expectedException \RuntimeException
206+
* @expectedExceptionMessage The node at path "foo" has no default value.
207+
*/
208+
public function testGetDefaultValueWithoutDefaultValue()
209+
{
210+
$node = new ArrayNode('foo');
211+
$node->getDefaultValue();
212+
}
176213
}

‎src/Symfony/Component/Console/Descriptor/TextDescriptor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ protected function describeCommand(Command $command, array $options = array())
156156
$this->writeText("\n");
157157
$this->writeText('<comment>Help:</comment>', $options);
158158
$this->writeText("\n");
159-
$this->writeText(' '.str_replace("\n", "\n ", $help), $options);
159+
$this->writeText(' '.str_replace("\n", "\n ", $help), $options);
160160
$this->writeText("\n");
161161
}
162162
}

‎src/Symfony/Component/Console/Tests/Fixtures/application_run2.txt

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ Options:
99
--format=FORMAT The output format (txt, xml, json, or md) [default: "txt"]
1010

1111
Help:
12-
The list command lists all commands:
13-
14-
php app/console list
15-
16-
You can also display the commands for a specific namespace:
17-
18-
php app/console list test
19-
20-
You can also output the information in other formats by using the --format option:
21-
22-
php app/console list --format=xml
23-
24-
It's also possible to get raw list of commands (useful for embedding command runner):
25-
26-
php app/console list --raw
12+
The list command lists all commands:
13+
14+
php app/console list
15+
16+
You can also display the commands for a specific namespace:
17+
18+
php app/console list test
19+
20+
You can also output the information in other formats by using the --format option:
21+
22+
php app/console list --format=xml
23+
24+
It's also possible to get raw list of commands (useful for embedding command runner):
25+
26+
php app/console list --raw

‎src/Symfony/Component/Console/Tests/Fixtures/application_run3.txt

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ Options:
99
--format=FORMAT The output format (txt, xml, json, or md) [default: "txt"]
1010

1111
Help:
12-
The list command lists all commands:
13-
14-
php app/console list
15-
16-
You can also display the commands for a specific namespace:
17-
18-
php app/console list test
19-
20-
You can also output the information in other formats by using the --format option:
21-
22-
php app/console list --format=xml
23-
24-
It's also possible to get raw list of commands (useful for embedding command runner):
25-
26-
php app/console list --raw
12+
The list command lists all commands:
13+
14+
php app/console list
15+
16+
You can also display the commands for a specific namespace:
17+
18+
php app/console list test
19+
20+
You can also output the information in other formats by using the --format option:
21+
22+
php app/console list --format=xml
23+
24+
It's also possible to get raw list of commands (useful for embedding command runner):
25+
26+
php app/console list --raw

‎src/Symfony/Component/Console/Tests/Fixtures/command_1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
alias2
55

66
<comment>Help:</comment>
7-
command 1 help
7+
command 1 help

‎src/Symfony/Component/Console/Tests/Fixtures/command_2.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
<info>-o, --option_name</info>
1111

1212
<comment>Help:</comment>
13-
command 2 help
13+
command 2 help

‎src/Symfony/Component/Console/Tests/Fixtures/command_astext.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
<info>-v|vv|vvv, --verbose</info> Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug
1616

1717
<comment>Help:</comment>
18-
help
18+
help

‎src/Symfony/Component/Intl/Intl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ public static function getIcuDataVersion()
234234
*/
235235
public static function getIcuStubVersion()
236236
{
237-
return '55.1';
237+
return '57.1';
238238
}
239239

240240
/**

‎src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,8 +252,8 @@ class NumberFormatter
252252
);
253253

254254
private static $enTextAttributes = array(
255-
self::DECIMAL => array('', '', '-', '', '*', '', ''),
256-
self::CURRENCY => array('¤', '', '-¤', '', '*', ''),
255+
self::DECIMAL => array('', '', '-', '', ' ', '', ''),
256+
self::CURRENCY => array('¤', '', '-¤', '', ' ', ''),
257257
);
258258

259259
/**

0 commit comments

Comments
 (0)