bug #48288 [Security] Make onAuthenticationSuccess Response optional (db306)

fabpot · fabpot · commit e1bcdd56561e · 2023-04-21T13:51:14.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [Security] Make onAuthenticationSuccess Response optional | Q | A | ------------- | --- | Branch? | 6.0, 6.1, and 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT Most authenticators currently use onAuthenticationSuccess with an optional Response. That's mainly due to usecases whereby we want to redirect specific users etc. Commits ------- 1e95ac7 Make onAuthenticationSuccess Response optional
diff --git a/src/Symfony/Component/Security/Http/Authentication/AuthenticationSuccessHandlerInterface.php b/src/Symfony/Component/Security/Http/Authentication/AuthenticationSuccessHandlerInterface.php
@@ -29,5 +29,5 @@ interface AuthenticationSuccessHandlerInterface
     /**
      * Usually called by AuthenticatorInterface::onAuthenticationSuccess() implementations.
      */
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response;
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token): ?Response;
 }

Original file line number	Diff line number	Diff line change
`@@ -29,5 +29,5 @@ interface AuthenticationSuccessHandlerInterface`
`29`	`29`	`/**`
`30`	`30`	`* Usually called by AuthenticatorInterface::onAuthenticationSuccess() implementations.`
`31`	`31`	`*/`
`32`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response;`
	`32`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token): ?Response;`
`33`	`33`	`}`