minor #18456 [Form] Remove unnecessary option assignment (sergeyfedotov)

Tobion · Tobion · commit e251e364673e · 2016-04-06T13:21:17.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [Form] Remove unnecessary option assignment | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Option assignment is not required because the prototype inherits this option from the parent form via standard inheritance mechanism. Related pull requests: #16959, #18317 Commits ------- da8a197 Remove unnecessary option assignment
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php b/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
@@ -28,7 +28,6 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     {
         if ($options['allow_add'] && $options['prototype']) {
             $prototype = $builder->create($options['prototype_name'], $options['type'], array_replace(array(
-                'required' => $options['required'],
                 'label' => $options['prototype_name'].'label__',
             ), $options['options']));
             $builder->setAttribute('prototype', $prototype->getForm());

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ public function buildForm(FormBuilderInterface $builder, array $options)`
`28`	`28`	`{`
`29`	`29`	`if ($options['allow_add'] && $options['prototype']) {`
`30`	`30`	`$prototype = $builder->create($options['prototype_name'], $options['type'], array_replace(array(`
`31`		`- 'required' => $options['required'],`
`32`	`31`	`'label' => $options['prototype_name'].'label__',`
`33`	`32`	`), $options['options']));`
`34`	`33`	`$builder->setAttribute('prototype', $prototype->getForm());`