[FrameworkBundle] Display a proper warning for deprecated --env and --no-debug options

Robin Chalas · Robin Chalas · commit e3aadcb933a2 · 2018-10-28T12:45:34.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Console/Application.php b/src/Symfony/Bundle/FrameworkBundle/Console/Application.php
@@ -63,11 +63,16 @@ public function getKernel()
     public function doRun(InputInterface $input, OutputInterface $output)
     {
         if ($input->hasParameterOption(array('-e', '--env'), true)) {
-            @trigger_error('The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.', E_USER_DEPRECATED);
+            $notice = 'The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.';
+            $io = (new SymfonyStyle($input, $output))->getErrorStyle();
+            $io->warning($notice);
+            @trigger_error($notice, E_USER_DEPRECATED);
         }
 
         if ($input->hasParameterOption('--no-debug', true)) {
-            @trigger_error('The "--no-debug" option is deprecated since Symfony 4.2. Set the "APP_DEBUG" environment variable to "0" instead.', E_USER_DEPRECATED);
+            $notice = 'The "--no-debug" option is deprecated since Symfony 4.2. Set the "APP_DEBUG" environment variable to "0" instead.';
+            ($io ?? (new SymfonyStyle($input, $output))->getErrorStyle())->warning($notice);
+            @trigger_error($notice, E_USER_DEPRECATED);
         }
 
         $this->kernel->boot();

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,16 @@ public function getKernel()`
`63`	`63`	`public function doRun(InputInterface $input, OutputInterface $output)`
`64`	`64`	`{`
`65`	`65`	`if ($input->hasParameterOption(array('-e', '--env'), true)) {`
`66`		`- @trigger_error('The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.', E_USER_DEPRECATED);`
	`66`	`+ $notice = 'The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.';`
	`67`	`+ $io = (new SymfonyStyle($input, $output))->getErrorStyle();`
	`68`	`+ $io->warning($notice);`
	`69`	`+ @trigger_error($notice, E_USER_DEPRECATED);`
`67`	`70`	`}`
`68`	`71`
`69`	`72`	`if ($input->hasParameterOption('--no-debug', true)) {`
`70`		`- @trigger_error('The "--no-debug" option is deprecated since Symfony 4.2. Set the "APP_DEBUG" environment variable to "0" instead.', E_USER_DEPRECATED);`
	`73`	`+ $notice = 'The "--no-debug" option is deprecated since Symfony 4.2. Set the "APP_DEBUG" environment variable to "0" instead.';`
	`74`	`+ ($io ?? (new SymfonyStyle($input, $output))->getErrorStyle())->warning($notice);`
	`75`	`+ @trigger_error($notice, E_USER_DEPRECATED);`
`71`	`76`	`}`
`72`	`77`
`73`	`78`	`$this->kernel->boot();`