[Console] Fix backslash escaping in bash completion

GromNaN · GromNaN · commit e4202a0960dc · 2021-10-29T18:14:38.000+02:00
diff --git a/src/Symfony/Component/Console/Completion/Output/BashCompletionOutput.php b/src/Symfony/Component/Console/Completion/Output/BashCompletionOutput.php
@@ -27,6 +27,10 @@ public function write(CompletionSuggestions $suggestions, OutputInterface $outpu
         }
         $output->write(implode(' ', $options));
 
-        $output->writeln(implode(' ', $suggestions->getValueSuggestions()));
+        $values = array_map(function ($value) {
+            return str_replace('\\', '\\\\\\\\', $value);
+        }, $suggestions->getValueSuggestions());
+
+        $output->writeln(implode(' ', $values));
     }
 }
diff --git a/src/Symfony/Component/Console/Resources/completion.bash b/src/Symfony/Component/Console/Resources/completion.bash
@@ -16,12 +16,12 @@ _sf_{{ COMMAND_NAME }}() {
 
     local completecmd=("$sf_cmd" "_complete" "-sbash" "-c$cword" "-S{{ VERSION }}")
     for w in ${words[@]}; do
-        completecmd+=(-i "'$w'")
+        completecmd+=($(printf -- '-i%b' "$w"))
     done
 
     local sfcomplete
     if sfcomplete=$(${completecmd[@]} 2>&1); then
-        COMPREPLY=($(compgen -W "$sfcomplete" -- "$cur"))
+        COMPREPLY=($(compgen -W "$sfcomplete" -- $(printf -- "%q" "$cur")))
         __ltrim_colon_completions "$cur"
     else
         if [[ "$sfcomplete" != *"Command \"_complete\" is not defined."* ]]; then

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@ public function write(CompletionSuggestions $suggestions, OutputInterface $outpu`
`27`	`27`	`}`
`28`	`28`	`$output->write(implode(' ', $options));`
`29`	`29`
`30`		`- $output->writeln(implode(' ', $suggestions->getValueSuggestions()));`
	`30`	`+ $values = array_map(function ($value) {`
	`31`	`+ return str_replace('\\', '\\\\\\\\', $value);`
	`32`	`+ }, $suggestions->getValueSuggestions());`
	`33`	`+`
	`34`	`+ $output->writeln(implode(' ', $values));`
`31`	`35`	`}`
`32`	`36`	`}`