Definition::addMethodCall() expects arg 3 to be bool

Girgias · Girgias · commit e59b17cdcb4b · 2025-07-11T12:14:20.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php
@@ -85,7 +85,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
             $setters = $value->getMethodCalls();
             $value->setMethodCalls($withers);
             foreach ($setters as $call) {
-                $value->addMethodCall($call[0], $call[1], $call[2] ?? false);
+                $value->addMethodCall($call[0], $call[1], isset($call[2]) && $call[2]);
             }
         }
 
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -339,7 +339,12 @@ private function parseDefinition(\DOMElement $service, string $file, Definition
         }
 
         foreach ($this->getChildren($service, 'call') as $call) {
-            $definition->addMethodCall($call->getAttribute('method'), $this->getArgumentsAsPhp($call, 'argument', $file), XmlUtils::phpize($call->getAttribute('returns-clone')));
+            $returnClone = $call->getAttribute('returns-clone');
+            $definition->addMethodCall(
+                $call->getAttribute('method'),
+                $this->getArgumentsAsPhp($call, 'argument', $file),
+                $returnClone !== '' ? XmlUtils::phpize($returnClone) : false
+            );
         }
 
         $tags = $this->getChildren($service, 'tag');

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed`
`85`	`85`	`$setters = $value->getMethodCalls();`
`86`	`86`	`$value->setMethodCalls($withers);`
`87`	`87`	`foreach ($setters as $call) {`
`88`		`- $value->addMethodCall($call[0], $call[1], $call[2] ?? false);`
	`88`	`+ $value->addMethodCall($call[0], $call[1], isset($call[2]) && $call[2]);`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`
Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,12 @@ private function parseDefinition(\DOMElement $service, string $file, Definition`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`foreach ($this->getChildren($service, 'call') as $call) {`
`342`		`- $definition->addMethodCall($call->getAttribute('method'), $this->getArgumentsAsPhp($call, 'argument', $file), XmlUtils::phpize($call->getAttribute('returns-clone')));`
	`342`	`+ $returnClone = $call->getAttribute('returns-clone');`
	`343`	`+ $definition->addMethodCall(`
	`344`	`+ $call->getAttribute('method'),`
	`345`	`+ $this->getArgumentsAsPhp($call, 'argument', $file),`
	`346`	`+ $returnClone !== '' ? XmlUtils::phpize($returnClone) : false`
	`347`	`+ );`
`343`	`348`	`}`
`344`	`349`
`345`	`350`	`$tags = $this->getChildren($service, 'tag');`