minor #61094 [Routing] Add test to validate that default value is allowed to not match requirement (tcoch)

nicolas-grekas · nicolas-grekas · commit e5d6c572869e · 2025-07-15T10:46:41.000+02:00
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Routing] Add test to validate that default value is allowed to not match requirement | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | #61022 | License | MIT Suppose you have this route definition: ```php $route = new Route('/test/{foo}', ['foo' => 'foo-'], ['foo' => '\w+'], []); ``` With this route definition: - `/test/foo` works - `/test/foo-` fails, because the dash is not permitted by the requirement - `/test` works, thanks to the default value. However, the value of the parameter `foo` does not meet the requirement. Commits ------- f6e91fd [Routing] Add test to validate that default value is allowed to not match requirement
diff --git a/src/Symfony/Component/Routing/Tests/Matcher/UrlMatcherTest.php b/src/Symfony/Component/Routing/Tests/Matcher/UrlMatcherTest.php
@@ -982,6 +982,30 @@ public function testUtf8VarName()
         $this->assertEquals(['_route' => 'foo', 'bär' => 'baz', 'bäz' => 'foo'], $matcher->match('/foo/baz'));
     }
 
+    public function testParameterWithRequirementWithDefault()
+    {
+        $collection = new RouteCollection();
+
+        $route = new Route('/test/{foo}', ['foo' => 'foo-'], ['foo' => '\w+']);
+        $collection->add('test', $route);
+
+        $matcher = $this->getUrlMatcher($collection);
+
+        $result = $matcher->match('/test/foo');
+        $this->assertSame('test', $result['_route']);
+        $this->assertSame('foo', $result['foo']);
+
+        try {
+            $matcher->match('/test/foo-');
+        } catch (ResourceNotFoundException $e) {
+            $this->assertStringContainsString('No routes found', $e->getMessage());
+        }
+
+        $result = $matcher->match('/test');
+        $this->assertSame('test', $result['_route']);
+        $this->assertSame('foo-', $result['foo']);
+    }
+
     protected function getUrlMatcher(RouteCollection $routes, ?RequestContext $context = null)
     {
         return new UrlMatcher($routes, $context ?? new RequestContext());
