Allow to set block_id for SlackActionsBlock and set url to nullable, allow setting value in SlackButtonBlockElement

miloszowi · miloszowi · commit e687dff358cf · 2025-04-13T13:40:29.000+02:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackActionsBlock.php b/src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackActionsBlock.php
@@ -24,16 +24,24 @@ public function __construct()
     /**
      * @return $this
      */
-    public function button(string $text, string $url, ?string $style = null): static
+    public function button(string $text, ?string $url = null, ?string $style = null, ?string $value = null): static
     {
         if (25 === \count($this->options['elements'] ?? [])) {
             throw new \LogicException('Maximum number of buttons should not exceed 25.');
         }
 
-        $element = new SlackButtonBlockElement($text, $url, $style);
+        $element = new SlackButtonBlockElement($text, $url, $style, $value);
 
         $this->options['elements'][] = $element->toArray();
 
         return $this;
     }
+
+    /**
+     * @return $this
+     */
+    public function id(string $id): static
+    {
+        $this->options['block_id'] = $id;
+    }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackButtonBlockElement.php b/src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackButtonBlockElement.php
@@ -16,20 +16,27 @@
  */
 final class SlackButtonBlockElement extends AbstractSlackBlockElement
 {
-    public function __construct(string $text, string $url, ?string $style = null)
+    public function __construct(string $text, ?string $url = null, ?string $style = null, ?string $value = null)
     {
         $this->options = [
             'type' => 'button',
             'text' => [
                 'type' => 'plain_text',
                 'text' => $text,
             ],
-            'url' => $url,
         ];
 
+        if ($url) {
+            $this->options['url'] = $url;
+        }
+
         if ($style) {
             // primary or danger
             $this->options['style'] = $style;
         }
+
+        if ($value) {
+            $this->options['value'] = $value;
+        }
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackActionsBlockTest.php b/src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackActionsBlockTest.php
@@ -19,8 +19,9 @@ final class SlackActionsBlockTest extends TestCase
     public function testCanBeInstantiated()
     {
         $actions = new SlackActionsBlock();
-        $actions->button('first button text', 'https://example.org')
+        $actions->button('first button text', 'https://example.org', null, 'test-value')
             ->button('second button text', 'https://example.org/slack', 'danger')
+            ->button('third button text', null, null, 'test-value-3')
         ;
 
         $this->assertSame([
@@ -33,6 +34,7 @@ public function testCanBeInstantiated()
                         'text' => 'first button text',
                     ],
                     'url' => 'https://example.org',
+                    'value' => 'test-value'
                 ],
                 [
                     'type' => 'button',
@@ -43,6 +45,14 @@ public function testCanBeInstantiated()
                     'url' => 'https://example.org/slack',
                     'style' => 'danger',
                 ],
+                [
+                    'type' => 'button',
+                    'text' => [
+                        'type' => 'plain_text',
+                        'text' => 'third button text',
+                    ],
+                    'value' => 'test-value-3',
+                ]
             ],
         ], $actions->toArray());
     }

Original file line number	Diff line number	Diff line change
`@@ -24,16 +24,24 @@ public function __construct()`
`24`	`24`	`/**`
`25`	`25`	`* @return $this`
`26`	`26`	`*/`
`27`		`- public function button(string $text, string $url, ?string $style = null): static`
	`27`	`+ public function button(string $text, ?string $url = null, ?string $style = null, ?string $value = null): static`
`28`	`28`	`{`
`29`	`29`	`if (25 === \count($this->options['elements'] ?? [])) {`
`30`	`30`	`throw new \LogicException('Maximum number of buttons should not exceed 25.');`
`31`	`31`	`}`
`32`	`32`
`33`		`- $element = new SlackButtonBlockElement($text, $url, $style);`
	`33`	`+ $element = new SlackButtonBlockElement($text, $url, $style, $value);`
`34`	`34`
`35`	`35`	`$this->options['elements'][] = $element->toArray();`
`36`	`36`
`37`	`37`	`return $this;`
`38`	`38`	`}`
	`39`	`+`
	`40`	`+ /**`
	`41`	`+ * @return $this`
	`42`	`+ */`
	`43`	`+ public function id(string $id): static`
	`44`	`+ {`
	`45`	`+ $this->options['block_id'] = $id;`
	`46`	`+ }`
`39`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,20 +16,27 @@`
`16`	`16`	`*/`
`17`	`17`	`final class SlackButtonBlockElement extends AbstractSlackBlockElement`
`18`	`18`	`{`
`19`		`- public function __construct(string $text, string $url, ?string $style = null)`
	`19`	`+ public function __construct(string $text, ?string $url = null, ?string $style = null, ?string $value = null)`
`20`	`20`	`{`
`21`	`21`	`$this->options = [`
`22`	`22`	`'type' => 'button',`
`23`	`23`	`'text' => [`
`24`	`24`	`'type' => 'plain_text',`
`25`	`25`	`'text' => $text,`
`26`	`26`	`],`
`27`		`- 'url' => $url,`
`28`	`27`	`];`
`29`	`28`
	`29`	`+ if ($url) {`
	`30`	`+ $this->options['url'] = $url;`
	`31`	`+ }`
	`32`	`+`
`30`	`33`	`if ($style) {`
`31`	`34`	`// primary or danger`
`32`	`35`	`$this->options['style'] = $style;`
`33`	`36`	`}`
	`37`	`+`
	`38`	`+ if ($value) {`
	`39`	`+ $this->options['value'] = $value;`
	`40`	`+ }`
`34`	`41`	`}`
`35`	`42`	`}`