[Lock] Fixed StoreFactory to accept same DSN syntax as AbstractAdapter for memcached

Jontsa · Jontsa · commit e7ed9a4b76ea · 2020-03-31T20:46:47.000+03:00
diff --git a/src/Symfony/Component/Lock/Store/StoreFactory.php b/src/Symfony/Component/Lock/Store/StoreFactory.php
@@ -68,11 +68,11 @@ public static function createStore($connection)
 
             case 0 === strpos($connection, 'redis:'):
             case 0 === strpos($connection, 'rediss:'):
-            case 0 === strpos($connection, 'memcached://'):
+            case 0 === strpos($connection, 'memcached:'):
                 if (!class_exists(AbstractAdapter::class)) {
                     throw new InvalidArgumentException(sprintf('Unsupported DSN "%s". Try running "composer require symfony/cache".', $connection));
                 }
-                $storeClass = 0 === strpos($connection, 'memcached://') ? MemcachedStore::class : RedisStore::class;
+                $storeClass = 0 === strpos($connection, 'memcached:') ? MemcachedStore::class : RedisStore::class;
                 $connection = AbstractAdapter::createConnection($connection, ['lazy' => true]);
 
                 return new $storeClass($connection);
diff --git a/src/Symfony/Component/Lock/Tests/Store/StoreFactoryTest.php b/src/Symfony/Component/Lock/Tests/Store/StoreFactoryTest.php
@@ -58,6 +58,7 @@ public function validConnections()
         }
         if (class_exists(\Memcached::class) && class_exists(AbstractAdapter::class)) {
             yield ['memcached://server.com', MemcachedStore::class];
+            yield ['memcached:?host[localhost]&host[localhost:12345]', MemcachedStore::class];
         }
         if ((class_exists(\Redis::class) || class_exists(\Predis\Client::class)) && class_exists(AbstractAdapter::class)) {
             yield ['redis://localhost', RedisStore::class];

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ public function validConnections()`
`58`	`58`	`}`
`59`	`59`	`if (class_exists(\Memcached::class) && class_exists(AbstractAdapter::class)) {`
`60`	`60`	`yield ['memcached://server.com', MemcachedStore::class];`
	`61`	`+ yield ['memcached:?host[localhost]&host[localhost:12345]', MemcachedStore::class];`
`61`	`62`	`}`
`62`	`63`	`if ((class_exists(\Redis::class) \|\| class_exists(\Predis\Client::class)) && class_exists(AbstractAdapter::class)) {`
`63`	`64`	`yield ['redis://localhost', RedisStore::class];`