feature #31242 Update LoggingTranslator to log the change of a locale (gmponos)

fabpot · fabpot · commit e9db551ab04a · 2019-04-27T19:49:41.000+01:00
This PR was squashed before being merged into the 4.3-dev branch (closes #31242). Discussion ---------- Update LoggingTranslator to log the change of a locale | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT I would like to see inside my logs that the translator changed the locale. I've had a case that I spent significant amount of time trying to debug it. Commits ------- 20380f9 Update LoggingTranslator to log the change of a locale
diff --git a/src/Symfony/Component/Translation/LoggingTranslator.php b/src/Symfony/Component/Translation/LoggingTranslator.php
@@ -82,7 +82,9 @@ public function transChoice($id, $number, array $parameters = [], $domain = null
      */
     public function setLocale($locale)
     {
+        $prev = $this->translator->getLocale();
         $this->translator->setLocale($locale);
+        $this->logger->debug(sprintf('The locale of the translator has changed from "%s" to "%s".', $prev, $locale));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,9 @@ public function transChoice($id, $number, array $parameters = [], $domain = null`
`82`	`82`	`*/`
`83`	`83`	`public function setLocale($locale)`
`84`	`84`	`{`
	`85`	`+ $prev = $this->translator->getLocale();`
`85`	`86`	`$this->translator->setLocale($locale);`
	`87`	`+ $this->logger->debug(sprintf('The locale of the translator has changed from "%s" to "%s".', $prev, $locale));`
`86`	`88`	`}`
`87`	`89`
`88`	`90`	`/**`