Deprecate container params router.request_context.*

stollr · stollr · commit ec2dade194b6 · 2025-08-19T09:50:11.000+02:00
The `framework.router.default_uri` config is used to define the request context as fallback for the case that no HTTP request is available. But it does not affect the container params - `router.request_context.base_url` - `router.request_context.host` - `router.request_context.scheme` They still use the defaults, which are defined in the routing.php config file. This leads to inconsistency and confusion if a third party bundle relies on the container parameters instead of the request context service. This PR deprecates those container params like proposed in #53919.
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -33,6 +33,8 @@ FrameworkBundle
 ---------------
 
  * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `addCommand()`
+ * Deprecate the container params `router.request_context.scheme`, `router.request_context.host`
+   and `router.request_context.base_url`, use the `framework.router.default_uri` config instead.
 
 HtmlSanitizer
 -------------
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -8,6 +8,8 @@ CHANGELOG
  * Allow using their name without added suffix when using `#[Target]` for custom services
  * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `Symfony\Bundle\FrameworkBundle\Console\Application::addCommand()`
  * Add `assertEmailAddressNotContains()` to the `MailerAssertionsTrait`
+ * Deprecate the container params `router.request_context.scheme`, `router.request_context.host`
+   and `router.request_context.base_url`, use the `framework.router.default_uri` config instead.
 
 7.3
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1305,6 +1305,14 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co
             $container->removeDefinition('messenger.middleware.router_context');
         }
 
+        if (!isset($config['default_uri']) && (
+            $container->hasParameter('router.request_context.scheme')
+            || $container->hasParameter('router.request_context.host')
+            || $container->hasParameter('router.request_context.base_url')
+        )) {
+            trigger_deprecation('symfony/framework-bundle', '7.4', 'Deprecated the container params "router.request_context.scheme", "router.request_context.host" and "router.request_context.base_url", use the "framework.router.default_uri" config instead.');
+        }
+
         $loader->load('routing.php');
 
         if ($config['utf8']) {
