Skip to content

Commit ec6b882

Browse files
minor #23028 add some \ on PHP_VERSION_ID for 2.8 (vincentaubert)
This PR was merged into the 2.8 branch. Discussion ---------- add some \ on PHP_VERSION_ID for 2.8 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22650 | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Commits ------- 7f4824c add some \ on PHP_VERSION_ID for 2.8
2 parents 7a57644 + 7f4824c commit ec6b882

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/Symfony/Component/Console/Tests/Command/CommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ public function testSetCodeWithStaticClosure()
386386
$tester = new CommandTester($command);
387387
$tester->execute(array());
388388

389-
if (PHP_VERSION_ID < 70000) {
389+
if (\PHP_VERSION_ID < 70000) {
390390
// Cannot bind static closures in PHP 5
391391
$this->assertEquals('interact called'.PHP_EOL.'not bound'.PHP_EOL, $tester->getDisplay());
392392
} else {

src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@ public function testThatCloningIsNotSupported()
698698
{
699699
$class = new \ReflectionClass('Symfony\Component\DependencyInjection\Container');
700700
$clone = $class->getMethod('__clone');
701-
if (PHP_VERSION_ID >= 50400) {
701+
if (\PHP_VERSION_ID >= 50400) {
702702
$this->assertFalse($class->isCloneable());
703703
}
704704
$this->assertTrue($clone->isPrivate());

src/Symfony/Component/DomCrawler/Crawler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1191,7 +1191,7 @@ private function createSubCrawler($nodes)
11911191
private function triggerDeprecation($methodName, $useTrace = false)
11921192
{
11931193
if ($useTrace || defined('HHVM_VERSION')) {
1194-
if (PHP_VERSION_ID >= 50400) {
1194+
if (\PHP_VERSION_ID >= 50400) {
11951195
$trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 3);
11961196
} else {
11971197
$trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);

0 commit comments

Comments
 (0)