Merge branch '2.3' into 2.7

nicolas-grekas · nicolas-grekas · commit ec7b3f2053c9 · 2016-02-13T10:21:13.000+01:00
* 2.3: [DomCrawler] Clarify the value returned by getPhpFiles() [DependencyInjection] Fix #16461 Let Container::set() replace existing aliases Added more exceptions to singularify method
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -193,6 +193,10 @@ public function set($id, $service, $scope = self::SCOPE_CONTAINER)
             $this->scopedServices[$scope][$id] = $service;
         }
 
+        if (isset($this->aliases[$id])) {
+            unset($this->aliases[$id]);
+        }
+
         $this->services[$id] = $service;
 
         if (method_exists($this, $method = 'synchronize'.strtr($id, $this->underscoreMap).'Service')) {
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
@@ -218,6 +218,16 @@ public function testAddAliases()
         $this->assertTrue(isset($aliases['foobar']));
     }
 
+    public function testSetReplacesAlias()
+    {
+        $builder = new ContainerBuilder();
+        $builder->setAlias('alias', 'aliased');
+        $builder->set('aliased', new \stdClass());
+
+        $builder->set('alias', $foo = new \stdClass());
+        $this->assertSame($foo, $builder->get('alias'), '->set() replaces an existing alias');
+    }
+
     public function testAddGetCompilerPass()
     {
         $builder = new ContainerBuilder();
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -184,6 +184,14 @@ public function testSetAlsoCallsSynchronizeService()
         $this->assertTrue($c->synchronized, '->set() calls synchronize*Service() if it is defined for the service');
     }
 
+    public function testSetReplacesAlias()
+    {
+        $c = new ProjectServiceContainer();
+
+        $c->set('alias', $foo = new \stdClass());
+        $this->assertSame($foo, $c->get('alias'), '->set() replaces an existing alias');
+    }
+
     public function testGet()
     {
         $sc = new ProjectServiceContainer();
diff --git a/src/Symfony/Component/DomCrawler/Form.php b/src/Symfony/Component/DomCrawler/Form.php
@@ -157,8 +157,12 @@ public function getPhpValues()
      *
      * This method converts fields with the array notation
      * (like foo[bar] to arrays) like PHP does.
+     * The returned array is consistent with the array for field values
+     * (@see getPhpValues), rather than uploaded files found in $_FILES.
+     * For a compound file field foo[bar] it will create foo[bar][name],
+     * instead of foo[name][bar] which would be found in $_FILES.
      *
-     * @return array An array of field values.
+     * @return array An array of file field values.
      */
     public function getPhpFiles()
     {
diff --git a/src/Symfony/Component/PropertyAccess/StringUtil.php b/src/Symfony/Component/PropertyAccess/StringUtil.php
@@ -39,6 +39,9 @@ class StringUtil
         // nebulae (nebula)
         array('ea', 2, true, true, 'a'),
 
+        // services (service)
+        array('secivres', 8, true, true, 'service'),
+
         // mice (mouse), lice (louse)
         array('eci', 3, false, true, 'ouse'),
 
@@ -66,6 +69,12 @@ class StringUtil
         // movies (movie)
         array('seivom', 6, true, true, 'movie'),
 
+        // news (news)
+        array('swen', 4, true, true, 'news'),
+
+        // series (series)
+        array('seires', 6, true, true, 'series'),
+
         // babies (baby)
         array('sei', 3, false, true, 'y'),
 
diff --git a/src/Symfony/Component/PropertyAccess/Tests/StringUtilTest.php b/src/Symfony/Component/PropertyAccess/Tests/StringUtilTest.php
@@ -102,6 +102,7 @@ public function singularifyProvider()
             array('movies', 'movie'),
             array('nebulae', 'nebula'),
             array('neuroses', array('neuros', 'neurose', 'neurosis')),
+            array('news', 'news'),
             array('oases', array('oas', 'oase', 'oasis')),
             array('objectives', 'objective'),
             array('oxen', 'ox'),
@@ -120,6 +121,8 @@ public function singularifyProvider()
             array('scarves', array('scarf', 'scarve', 'scarff')),
             array('schemas', 'schema'), //schemata
             array('selfies', 'selfie'),
+            array('series', 'series'),
+            array('services', 'service'),
             array('sheriffs', 'sheriff'),
             array('shoes', array('sho', 'shoe')),
             array('spies', 'spy'),

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,10 @@ public function set($id, $service, $scope = self::SCOPE_CONTAINER)`
`193`	`193`	`$this->scopedServices[$scope][$id] = $service;`
`194`	`194`	`}`
`195`	`195`
	`196`	`+ if (isset($this->aliases[$id])) {`
	`197`	`+ unset($this->aliases[$id]);`
	`198`	`+ }`
	`199`	`+`
`196`	`200`	`$this->services[$id] = $service;`
`197`	`201`
`198`	`202`	`if (method_exists($this, $method = 'synchronize'.strtr($id, $this->underscoreMap).'Service')) {`
Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,14 @@ public function testSetAlsoCallsSynchronizeService()`
`184`	`184`	`$this->assertTrue($c->synchronized, '->set() calls synchronize*Service() if it is defined for the service');`
`185`	`185`	`}`
`186`	`186`
	`187`	`+ public function testSetReplacesAlias()`
	`188`	`+ {`
	`189`	`+ $c = new ProjectServiceContainer();`
	`190`	`+`
	`191`	`+ $c->set('alias', $foo = new \stdClass());`
	`192`	`+ $this->assertSame($foo, $c->get('alias'), '->set() replaces an existing alias');`
	`193`	`+ }`
	`194`	`+`
`187`	`195`	`public function testGet()`
`188`	`196`	`{`
`189`	`197`	`$sc = new ProjectServiceContainer();`
Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,12 @@ public function getPhpValues()`
`157`	`157`	`*`
`158`	`158`	`* This method converts fields with the array notation`
`159`	`159`	`* (like foo[bar] to arrays) like PHP does.`
	`160`	`+ * The returned array is consistent with the array for field values`
	`161`	`+ * (@see getPhpValues), rather than uploaded files found in $_FILES.`
	`162`	`+ * For a compound file field foo[bar] it will create foo[bar][name],`
	`163`	`+ * instead of foo[name][bar] which would be found in $_FILES.`
`160`	`164`	`*`
`161`		`- * @return array An array of field values.`
	`165`	`+ * @return array An array of file field values.`
`162`	`166`	`*/`
`163`	`167`	`public function getPhpFiles()`
`164`	`168`	`{`