[Process] Unset callback after stop to free memory

Slamdunk · stof · commit ec93b9a7f722 · 2015-12-05T11:16:20.000+01:00
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -1136,6 +1136,11 @@ private function close()
             $this->exitcode = 128 + $this->processInformation['termsig'];
         }
 
+        // Free memory from self-reference callback created by buildCallback
+        // Doing so in other contexts like __destruct or by garbage collector is ineffective
+        // Now pipes are closed, so the callback is no longer necessary
+        $this->callback = null;
+
         return $this->exitcode;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1136,6 +1136,11 @@ private function close()`
`1136`	`1136`	`$this->exitcode = 128 + $this->processInformation['termsig'];`
`1137`	`1137`	`}`
`1138`	`1138`
	`1139`	`+ // Free memory from self-reference callback created by buildCallback`
	`1140`	`+ // Doing so in other contexts like __destruct or by garbage collector is ineffective`
	`1141`	`+ // Now pipes are closed, so the callback is no longer necessary`
	`1142`	`+ $this->callback = null;`
	`1143`	`+`
`1139`	`1144`	`return $this->exitcode;`
`1140`	`1145`	`}`
`1141`	`1146`