feat: handle unknown currencies from an ISO 4217 POV

Crovitche-1623 · Crovitche-1623 · commit efac5e774eaf · 2025-08-22T12:01:49.000+02:00
diff --git a/src/Symfony/Component/Intl/Currencies.php b/src/Symfony/Component/Intl/Currencies.php
@@ -183,6 +183,10 @@ public static function forCountry(string $country, ?bool $legalTender = true, ?b
      */
     public static function isValidInCountry(string $country, string $currency, ?bool $legalTender = true, ?bool $active = true, \DateTimeInterface $date = new \DateTimeImmutable('today', new \DateTimeZone('Etc/UTC'))): bool
     {
+        if (!self::exists($currency)) {
+            throw new \InvalidArgumentException("The currency $currency does not exist.");
+        }
+
         try {
             $currencyMetadata = self::readEntry(['Map', $country, $currency], 'meta');
         } catch (MissingResourceException) {
@@ -240,6 +244,10 @@ private static function isDateActive(string $country, string $currency, array $c
      */
     public static function isValidInAnyCountry(string $currency, ?bool $legalTender = true, ?bool $active = true, \DateTimeInterface $date = new \DateTimeImmutable('today', new \DateTimeZone('Etc/UTC'))): bool
     {
+        if (!self::exists($currency)) {
+            throw new \InvalidArgumentException("The currency $currency does not exist.");
+        }
+
         foreach (self::readEntry(['Map'], 'meta') as $countryCode => $country) {
             foreach ($country as $currencyCode => $currencyMetadata) {
                 if ($currencyCode !== $currency) {
diff --git a/src/Symfony/Component/Intl/Tests/CurrenciesTest.php b/src/Symfony/Component/Intl/Tests/CurrenciesTest.php
@@ -882,4 +882,20 @@ public function testAntarticaHasNoCurrenciesIn2025()
     {
         $this->assertSame([], Currencies::forCountry('AQ', null, true, new \DateTimeImmutable('2025-01-01', new \DateTimeZone('Etc/UTC'))));
     }
+
+    public function testIsValidInCountryWithUnknownCurrencyThrowsException()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('The currency UNKNOWN-CURRENCY-FROM-ISO-4217 does not exist.');
+
+        Currencies::isValidInCountry('CH', 'UNKNOWN-CURRENCY-FROM-ISO-4217');
+    }
+
+    public function testIsValidInAnyCountryWithUnknownCurrencyThrowsException()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('The currency UNKNOWN-CURRENCY-FROM-ISO-4217 does not exist.');
+
+        Currencies::isValidInAnyCountry('UNKNOWN-CURRENCY-FROM-ISO-4217');
+    }
 }
