[Console] Add shell_exec check to Terminal::hasSttyAvailable()

maxbeckers · maxbeckers · commit f653612e07e0 · 2023-05-16T09:33:57.000+02:00
diff --git a/src/Symfony/Component/Console/Terminal.php b/src/Symfony/Component/Console/Terminal.php
@@ -65,7 +65,8 @@ public static function hasSttyAvailable(): bool
         }
 
         // skip check if exec function is disabled
-        if (!\function_exists('exec')) {
+        // shell_exec is very often used in the codebase after a Terminal::hasSttyAvailable() check, which can lead to a "Call to undefined function" error.
+        if (!\function_exists('exec') || !\function_exists('shell_exec')) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,8 @@ public static function hasSttyAvailable(): bool`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`// skip check if exec function is disabled`
`68`		`- if (!\function_exists('exec')) {`
	`68`	`+ // shell_exec is very often used in the codebase after a Terminal::hasSttyAvailable() check, which can lead to a "Call to undefined function" error.`
	`69`	`+ if (!\function_exists('exec') \|\| !\function_exists('shell_exec')) {`
`69`	`70`	`return false;`
`70`	`71`	`}`
`71`	`72`