[VarDumper] fix dumping uninitialized SplFileInfo

nicolas-grekas · nicolas-grekas · commit f702d1e02f94 · 2019-10-04T09:42:50.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Caster/SplCaster.php b/src/Symfony/Component/VarDumper/Caster/SplCaster.php
@@ -90,6 +90,12 @@ public static function castFileInfo(\SplFileInfo $c, array $a, Stub $stub, $isNe
 
         $prefix = Caster::PREFIX_VIRTUAL;
 
+        if (false === $c->getPathname()) {
+            $a[$prefix.'⚠'] = 'The parent constructor was not called: the object is in an invalid state';
+
+            return $a;
+        }
+
         foreach ($map as $key => $accessor) {
             try {
                 $a[$prefix.$key] = $c->$accessor();
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php
@@ -202,6 +202,21 @@ public function testArrayIterator()
     0 => 234
   ]
 }
+EOTXT;
+        $this->assertDumpEquals($expected, $var);
+    }
+
+    public function testBadSplFileInfo()
+    {
+        if (\defined('HHVM_VERSION')) {
+            $this->markTestSkipped('HHVM as different internal details.');
+        }
+        $var = new BadSplFileInfo();
+
+        $expected = <<<EOTXT
+Symfony\Component\VarDumper\Tests\Caster\BadSplFileInfo {
+  ⚠: "The parent constructor was not called: the object is in an invalid state"
+}
 EOTXT;
         $this->assertDumpEquals($expected, $var);
     }
@@ -211,3 +226,10 @@ class MyArrayIterator extends \ArrayIterator
 {
     private $foo = 123;
 }
+
+class BadSplFileInfo extends \SplFileInfo
+{
+    public function __construct()
+    {
+    }
+}
