[VarDumper] Move locale sniffing to dump() time

nicolas-grekas · nicolas-grekas · commit f77161b363eb · 2017-07-18T17:38:28.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Dumper/AbstractDumper.php b/src/Symfony/Component/VarDumper/Dumper/AbstractDumper.php
@@ -44,8 +44,7 @@ public function __construct($output = null, $charset = null, $flags = 0)
     {
         $this->flags = (int) $flags;
         $this->setCharset($charset ?: ini_get('php.output_encoding') ?: ini_get('default_charset') ?: 'UTF-8');
-        $this->decimalPoint = (string) 0.5;
-        $this->decimalPoint = $this->decimalPoint[1];
+        $this->decimalPoint = localeconv()['decimal_point'];
         $this->setOutput($output ?: static::$defaultOutput);
         if (!$output && is_string(static::$defaultOutput)) {
             static::$defaultOutput = $this->outputStream;
@@ -121,6 +120,8 @@ public function setIndentPad($pad)
      */
     public function dump(Data $data, $output = null)
     {
+        $this->decimalPoint = localeconv()['decimal_point'];
+
         if ($returnDump = true === $output) {
             $output = fopen('php://memory', 'r+b');
         }

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,7 @@ public function __construct($output = null, $charset = null, $flags = 0)`
`44`	`44`	`{`
`45`	`45`	`$this->flags = (int) $flags;`
`46`	`46`	`$this->setCharset($charset ?: ini_get('php.output_encoding') ?: ini_get('default_charset') ?: 'UTF-8');`
`47`		`- $this->decimalPoint = (string) 0.5;`
`48`		`- $this->decimalPoint = $this->decimalPoint[1];`
	`47`	`+ $this->decimalPoint = localeconv()['decimal_point'];`
`49`	`48`	`$this->setOutput($output ?: static::$defaultOutput);`
`50`	`49`	`if (!$output && is_string(static::$defaultOutput)) {`
`51`	`50`	`static::$defaultOutput = $this->outputStream;`
`@@ -121,6 +120,8 @@ public function setIndentPad($pad)`
`121`	`120`	`*/`
`122`	`121`	`public function dump(Data $data, $output = null)`
`123`	`122`	`{`
	`123`	`+ $this->decimalPoint = localeconv()['decimal_point'];`
	`124`	`+`
`124`	`125`	`if ($returnDump = true === $output) {`
`125`	`126`	`$output = fopen('php://memory', 'r+b');`
`126`	`127`	`}`