bug #14301 [FrameworkBundle][Translation] skip warmUp when cache is not used. (aitboudad)

aitboudad · aitboudad · commit f85ba5d74f6a · 2015-04-27T12:29:25.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle][Translation] skip warmUp when cache is not used. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #13942 | Tests pass? | yes | License | MIT Commits ------- efb10f6 [FrameworkBundle][Translation] skip warmUp when cache is not used.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Translation/Translator.php b/src/Symfony/Bundle/FrameworkBundle/Translation/Translator.php
@@ -77,6 +77,11 @@ public function __construct(ContainerInterface $container, MessageSelector $sele
      */
     public function warmUp($cacheDir)
     {
+        // skip warmUp when translator doesn't use cache
+        if (null === $this->options['cache_dir']) {
+            return;
+        }
+
         foreach ($this->resourceLocales as $locale) {
             $this->loadCatalogue($locale);
         }

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,11 @@ public function __construct(ContainerInterface $container, MessageSelector $sele`
`77`	`77`	`*/`
`78`	`78`	`public function warmUp($cacheDir)`
`79`	`79`	`{`
	`80`	`+ // skip warmUp when translator doesn't use cache`
	`81`	`+ if (null === $this->options['cache_dir']) {`
	`82`	`+ return;`
	`83`	`+ }`
	`84`	`+`
`80`	`85`	`foreach ($this->resourceLocales as $locale) {`
`81`	`86`	`$this->loadCatalogue($locale);`
`82`	`87`	`}`