add testcase

Ahummeling · Ahummeling · commit fadafdc9df77 · 2021-10-29T12:01:30.000+02:00
diff --git a/src/Symfony/Component/HttpKernel/CacheWarmer/CacheWarmerAggregate.php b/src/Symfony/Component/HttpKernel/CacheWarmer/CacheWarmerAggregate.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\HttpKernel\CacheWarmer;
 
+use Symfony\Component\HttpKernel\Tests\CacheWarmer\CacheWarmerAggregateTest;
+
 /**
  * Aggregates several cache warmers into a single one.
  *
@@ -50,7 +52,7 @@ public function enableOnlyOptionalWarmers()
      */
     public function warmUp($cacheDir)
     {
-        if ($collectDeprecations = $this->debug && !\defined('PHPUNIT_COMPOSER_INSTALL')) {
+        if ($collectDeprecations = $this->debug && (!\defined('PHPUNIT_COMPOSER_INSTALL') || file_exists(CacheWarmerAggregateTest::$emptyFile))) {
             $collectedLogs = [];
             $previousHandler = set_error_handler(function ($type, $message, $file, $line) use (&$collectedLogs, &$previousHandler) {
                 if (\E_USER_DEPRECATED !== $type && \E_DEPRECATED !== $type) {
diff --git a/src/Symfony/Component/HttpKernel/Tests/CacheWarmer/CacheWarmerAggregateTest.php b/src/Symfony/Component/HttpKernel/Tests/CacheWarmer/CacheWarmerAggregateTest.php
@@ -17,11 +17,13 @@
 
 class CacheWarmerAggregateTest extends TestCase
 {
+    public static $emptyFile;
     protected static $cacheDir;
 
     public static function setUpBeforeClass(): void
     {
         self::$cacheDir = tempnam(sys_get_temp_dir(), 'sf_cache_warmer_dir');
+        self::$emptyFile = tempnam(sys_get_temp_dir(), 'empty_file');
     }
 
     public static function tearDownAfterClass(): void
@@ -68,4 +70,12 @@ public function testWarmupDoesNotCallWarmupOnOptionalWarmersWhenEnableOptionalWa
         $aggregate = new CacheWarmerAggregate([$warmer]);
         $aggregate->warmUp(self::$cacheDir);
     }
+
+    public function testWarmupEmptyFile()
+    {
+        file_put_contents(self::$emptyFile, null);
+        self::assertFalse(unserialize(file_get_contents(self::$emptyFile)));
+        $aggregate = new CacheWarmerAggregate([], true, self::$emptyFile);
+        $aggregate->warmUp(self::$cacheDir);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -17,11 +17,13 @@`
`17`	`17`
`18`	`18`	`class CacheWarmerAggregateTest extends TestCase`
`19`	`19`	`{`
	`20`	`+ public static $emptyFile;`
`20`	`21`	`protected static $cacheDir;`
`21`	`22`
`22`	`23`	`public static function setUpBeforeClass(): void`
`23`	`24`	`{`
`24`	`25`	`self::$cacheDir = tempnam(sys_get_temp_dir(), 'sf_cache_warmer_dir');`
	`26`	`+ self::$emptyFile = tempnam(sys_get_temp_dir(), 'empty_file');`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`public static function tearDownAfterClass(): void`
`@@ -68,4 +70,12 @@ public function testWarmupDoesNotCallWarmupOnOptionalWarmersWhenEnableOptionalWa`
`68`	`70`	`$aggregate = new CacheWarmerAggregate([$warmer]);`
`69`	`71`	`$aggregate->warmUp(self::$cacheDir);`
`70`	`72`	`}`
	`73`	`+`
	`74`	`+ public function testWarmupEmptyFile()`
	`75`	`+ {`
	`76`	`+ file_put_contents(self::$emptyFile, null);`
	`77`	`+ self::assertFalse(unserialize(file_get_contents(self::$emptyFile)));`
	`78`	`+ $aggregate = new CacheWarmerAggregate([], true, self::$emptyFile);`
	`79`	`+ $aggregate->warmUp(self::$cacheDir);`
	`80`	`+ }`
`71`	`81`	`}`