Skip to content

Commit fd5f1e8

Browse files
committed
#39102: thank you fabbot.
1 parent 9524c3f commit fd5f1e8

File tree

8 files changed

+28
-26
lines changed

8 files changed

+28
-26
lines changed

src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer_debug.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
->set('data_collector.serializer', SerializerDataCollector::class)
2727
->args([service('debug.serializer'), tagged_iterator('debug.normalizer')])
28-
->tag('data_collector', ['template' => '@WebProfiler/Collector/serializer.html.twig','id' => 'serializer'])
28+
->tag('data_collector', ['template' => '@WebProfiler/Collector/serializer.html.twig', 'id' => 'serializer'])
2929

3030
->set('debug.serializer.action_factory', SerializerActionFactory::class)
3131

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/SerializerDebugPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class SerializerDebugPassTest extends TestCase
2323
{
2424
private const NORMALIZER_TAG = 'serializer.normalizer';
2525

26-
public function testProcess(): void
26+
public function testProcess()
2727
{
2828
$serializerDebugPass = new SerializerDebugPass();
2929
$container = new ContainerBuilder();

src/Symfony/Component/Serializer/Debug/LargeContent.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ final class LargeContent
1818
public function __construct()
1919
{
2020
$this->message = sprintf(
21-
"The content of the serialized/deserialized data exceeded %d kB.",
21+
'The content of the serialized/deserialized data exceeded %d kB.',
2222
self::LIMIT_BYTES / 1024
2323
);
2424
}

src/Symfony/Component/Serializer/Debug/Normalizer/AbstractTraceableNormalizer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,6 @@ public function __call($name, $arguments)
116116
return $this->delegate->$name(...$arguments);
117117
}
118118

119-
throw new \LogicException('Unexpected method call');
119+
throw new \LogicException('Unexpected method call.');
120120
}
121121
}

src/Symfony/Component/Serializer/Debug/SerializerActionFactory.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function createSerialization($data, string $result, string $format, array
5050
);
5151
}
5252

53-
public function createDeserialization(string $data, $result, string $type, string $format, array $context = [] ): Deserialization
53+
public function createDeserialization(string $data, $result, string $type, string $format, array $context = []): Deserialization
5454
{
5555
return new Deserialization(
5656
$this->sanitize($data),
@@ -63,6 +63,7 @@ public function createDeserialization(string $data, $result, string $type, strin
6363

6464
/**
6565
* @param mixed $data
66+
*
6667
* @return mixed|string|LargeContent
6768
*/
6869
private function sanitize($data)
@@ -76,12 +77,13 @@ private function sanitize($data)
7677

7778
/**
7879
* @param mixed $data
80+
*
7981
* @return string|LargeContent
8082
*/
8183
private function markAsHugeContent($data)
8284
{
8385
$output = new LargeContent();
84-
if (is_string($data)) {
86+
if (\is_string($data)) {
8587
return (string) $output;
8688
}
8789

@@ -90,6 +92,6 @@ private function markAsHugeContent($data)
9092

9193
private function getVarSize($data): int
9294
{
93-
return \mb_strlen(serialize($data), 'UTF-8') ?? 0;
95+
return mb_strlen(serialize($data), 'UTF-8') ?? 0;
9496
}
9597
}

src/Symfony/Component/Serializer/Tests/Debug/Normalizer/TraceableNormalizersTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ final class TraceableNormalizersTest extends TestCase
4848
private $hybridDelegate;
4949
private $serializerActionFactory;
5050

51-
public function testInterfaces(): void
51+
public function testInterfaces()
5252
{
5353
self::assertInstanceOf(NormalizerInterface::class, $this->traceableNormalizer);
5454
self::assertInstanceOf(DenormalizerInterface::class, $this->traceableDenormalizer);
@@ -208,7 +208,7 @@ public function provideDataForDenormalizationDelegation(): iterable
208208
];
209209
}
210210

211-
public function testAwarenessDelegation(): void
211+
public function testAwarenessDelegation()
212212
{
213213
$serializer = $this->createMock(SerializerInterface::class);
214214
$delegate = new TestSerializerNormalizerDenormalizerAware();
@@ -232,12 +232,12 @@ public function testCacheableSupport(bool $isCachable): void
232232
self::assertSame($isCachable, $tracer->hasCacheableSupportsMethod());
233233
}
234234

235-
public function testCacheableSupportOnNonCacheableDelegates(): void
235+
public function testCacheableSupportOnNonCacheableDelegates()
236236
{
237237
self::assertFalse($this->traceableNormalizer->hasCacheableSupportsMethod());
238238
}
239239

240-
public function testCallingUnknownMethodsOnDelegates(): void
240+
public function testCallingUnknownMethodsOnDelegates()
241241
{
242242
$delegate = new class() implements NormalizerInterface {
243243
public function normalize($object, string $format = null, array $context = [])
@@ -258,7 +258,7 @@ public function someAction(string $text)
258258
self::assertSame('foo', $tracer->someAction('foo'));
259259
}
260260

261-
public function testCallingUnknownButNotExistingMethodsOnDelegates(): void
261+
public function testCallingUnknownButNotExistingMethodsOnDelegates()
262262
{
263263
$this->expectException(\LogicException::class);
264264
$this->traceableNormalizer->someAction('foo');
@@ -279,8 +279,8 @@ protected function setUp(): void
279279
$serializerActionFactory = $this->getSerializerActionFactory();
280280

281281
$this->traceableNormalizer = new TraceableNormalizer($this->normalizerDelegate, $serializerActionFactory);
282-
$this->traceableDenormalizer = new TraceableDenormalizer($this->denormalizerDelegate,$serializerActionFactory);
283-
$this->traceableHybridNormalizer = new TraceableHybridNormalizer($this->hybridDelegate,$serializerActionFactory);
282+
$this->traceableDenormalizer = new TraceableDenormalizer($this->denormalizerDelegate, $serializerActionFactory);
283+
$this->traceableHybridNormalizer = new TraceableHybridNormalizer($this->hybridDelegate, $serializerActionFactory);
284284
}
285285

286286
private function getSerializerActionFactory(): SerializerActionFactory

src/Symfony/Component/Serializer/Tests/Debug/SerializerActionFactoryTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@
1818

1919
final class SerializerActionFactoryTest extends TestCase
2020
{
21-
private const EXPECTED_STRING_RESULT = "The content of the serialized/deserialized data exceeded 1024 kB.";
21+
private const EXPECTED_STRING_RESULT = 'The content of the serialized/deserialized data exceeded 1024 kB.';
2222
private static $hugeContent;
2323
private static $obj;
2424
private $factory;
2525

2626
public static function setUpBeforeClass(): void
2727
{
28-
self::$hugeContent = \str_repeat('X', 2000000);
28+
self::$hugeContent = str_repeat('X', 2000000);
2929

3030
self::$obj = new \stdClass();
3131
self::$obj->message = self::$hugeContent;
3232
}
3333

34-
public function testCreateLargeContentObjects(): void
34+
public function testCreateLargeContentObjects()
3535
{
3636
self::assertSame(
3737
self::EXPECTED_STRING_RESULT,
@@ -54,7 +54,7 @@ public function testCreateLargeContentObjects(): void
5454
);
5555
}
5656

57-
public function testCreateLargeContentObjectsWithDelegate(): void
57+
public function testCreateLargeContentObjectsWithDelegate()
5858
{
5959
self::assertSame(
6060
self::EXPECTED_STRING_RESULT,

src/Symfony/Component/Serializer/Tests/Debug/TraceableSerializerTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ protected function setUp(): void
4545
$this->emptyContext = [];
4646
}
4747

48-
public function testTracerIsSerializer(): void
48+
public function testTracerIsSerializer()
4949
{
5050
self::assertInstanceOf('Symfony\Component\Serializer\SerializerInterface', $this->traceableSerializer);
5151
self::assertInstanceOf('Symfony\Contracts\Service\ResetInterface', $this->traceableSerializer);
5252
}
5353

54-
public function testSerializeMustCallDelegate(): void
54+
public function testSerializeMustCallDelegate()
5555
{
5656
$this->assertSerializeToBeCalled();
5757

@@ -61,7 +61,7 @@ public function testSerializeMustCallDelegate(): void
6161
);
6262
}
6363

64-
public function testTracerAddsSerializationToSerializationsStack(): void
64+
public function testTracerAddsSerializationToSerializationsStack()
6565
{
6666
$this->assertSerializeToBeCalled();
6767

@@ -70,7 +70,7 @@ public function testTracerAddsSerializationToSerializationsStack(): void
7070
self::assertCount(1, $this->traceableSerializer->getSerializations());
7171
}
7272

73-
public function testCollectedSerializationContainsResultOfSerialization(): void
73+
public function testCollectedSerializationContainsResultOfSerialization()
7474
{
7575
$this->assertSerializeToBeCalled();
7676

@@ -80,7 +80,7 @@ public function testCollectedSerializationContainsResultOfSerialization(): void
8080
self::assertSame(self::SERIALIZED_OBJECT, $serializations[0]->result);
8181
}
8282

83-
public function testDeserializeMustCallDelegate(): void
83+
public function testDeserializeMustCallDelegate()
8484
{
8585
$this->assertDeserializeToBeCalled();
8686

@@ -95,7 +95,7 @@ public function testDeserializeMustCallDelegate(): void
9595
);
9696
}
9797

98-
public function testTracerAddsDeserializationToDeserializationsStack(): void
98+
public function testTracerAddsDeserializationToDeserializationsStack()
9999
{
100100
$this->assertDeserializeToBeCalled();
101101

@@ -104,7 +104,7 @@ public function testTracerAddsDeserializationToDeserializationsStack(): void
104104
self::assertCount(1, $this->traceableSerializer->getDeserializations());
105105
}
106106

107-
public function testCollectedDeserializationContainsResultOfDescerialization(): void
107+
public function testCollectedDeserializationContainsResultOfDescerialization()
108108
{
109109
$this->assertDeserializeToBeCalled();
110110

@@ -114,7 +114,7 @@ public function testCollectedDeserializationContainsResultOfDescerialization():
114114
self::assertSame($this->something, $deserializations[0]->result);
115115
}
116116

117-
public function testResetClearsSerializationsAndDeserializationsStacks(): void
117+
public function testResetClearsSerializationsAndDeserializationsStacks()
118118
{
119119
$this->assertSerializeToBeCalled();
120120
$this->assertDeserializeToBeCalled();

0 commit comments

Comments
 (0)