minor #61360 [Mailer] Fix expected exception message to include quotes around "http(s)://" (santysisi)

xabbuh · xabbuh · commit fe8a2dee5855 · 2025-08-08T08:50:32.000+02:00
This PR was merged into the 7.4 branch. Discussion ---------- [Mailer] Fix expected exception message to include quotes around "http(s)://" | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | no | License | MIT ### What does this PR do? This PR updates a test assertion to match the actual exception message being thrown in the code. The test was previously expecting the message: `<failingType> endpoint needs to be provided without http(s)://.` But the actual exception thrown is: `<failingType> endpoint needs to be provided without "http(s)://".` The discrepancy caused the test to fail. This fix ensures the test correctly reflects the expected output, including the necessary double quotes. ### Changes made - Updated `$this->expectExceptionMessage(...)` to include the quoted string `"http(s)://"`. No other logic or behavior has been changed. ### References * [MicrosoftGraphTransportFactory.php#L47-L53](https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php#L47-L53) The exception is thrown with `"http(s)://"` in quotes. * [MicrosoftGraphTransportFactoryTest.php#L87](https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Tests/Transport/MicrosoftGraphTransportFactoryTest.php#L87) The test incorrectly expects the message without quotes. Commits ------- e4398e6 [Mailer] Fix expected exception message to include quotes around "http(s)://"
diff --git a/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Tests/Transport/MicrosoftGraphTransportFactoryTest.php b/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Tests/Transport/MicrosoftGraphTransportFactoryTest.php
@@ -84,7 +84,7 @@ public function testValidatesHttpNotProvided(string $graph, string $auth, string
         $dsn = new Dsn('microsoftgraph+api', $graph, self::USER, self::PASSWORD, null, ['tenantId' => self::TENANT, 'authEndpoint' => $auth]);
 
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage($failingType.' endpoint needs to be provided without http(s)://.');
+        $this->expectExceptionMessage($failingType.' endpoint needs to be provided without "http(s)://".');
         $factory->create($dsn);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public function testValidatesHttpNotProvided(string $graph, string $auth, string`
`84`	`84`	`$dsn = new Dsn('microsoftgraph+api', $graph, self::USER, self::PASSWORD, null, ['tenantId' => self::TENANT, 'authEndpoint' => $auth]);`
`85`	`85`
`86`	`86`	`$this->expectException(InvalidArgumentException::class);`
`87`		`- $this->expectExceptionMessage($failingType.' endpoint needs to be provided without http(s)://.');`
	`87`	`+ $this->expectExceptionMessage($failingType.' endpoint needs to be provided without "http(s)://".');`
`88`	`88`	`$factory->create($dsn);`
`89`	`89`	`}`
`90`	`90`