[Cache] fix compat with apcu < 5.1.10

nicolas-grekas · nicolas-grekas · commit ff25e4adaa3a · 2021-12-26T20:04:24.000+01:00
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/AdapterTestCase.php b/src/Symfony/Component/Cache/Tests/Adapter/AdapterTestCase.php
@@ -296,6 +296,15 @@ public function testWeirdDataMatchingMetadataWrappedValues()
 
         $this->assertTrue($cache->hasItem('foobar'));
     }
+
+    public function testNullByteInKey()
+    {
+        $cache = $this->createCachePool(0, __FUNCTION__);
+
+        $cache->save($cache->getItem("a\0b")->set(123));
+
+        $this->assertSame(123, $cache->getItem("a\0b")->get());
+    }
 }
 
 class NotUnserializable
diff --git a/src/Symfony/Component/Cache/Traits/ApcuTrait.php b/src/Symfony/Component/Cache/Traits/ApcuTrait.php
@@ -54,7 +54,14 @@ protected function doFetch(array $ids)
         $unserializeCallbackHandler = ini_set('unserialize_callback_func', __CLASS__.'::handleUnserializeCallback');
         try {
             $values = [];
-            foreach (apcu_fetch($ids, $ok) ?: [] as $k => $v) {
+            $ids = array_flip($ids);
+            foreach (apcu_fetch(array_keys($ids)) ?: [] as $k => $v) {
+                if (!isset($ids[$k])) {
+                    // work around https://github.com/krakjoe/apcu/issues/247
+                    $k = key($ids);
+                }
+                unset($keys[$id]);
+
                 if (null !== $v || $ok) {
                     $values[$k] = $v;
                 }

Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,15 @@ public function testWeirdDataMatchingMetadataWrappedValues()`
`296`	`296`
`297`	`297`	`$this->assertTrue($cache->hasItem('foobar'));`
`298`	`298`	`}`
	`299`	`+`
	`300`	`+ public function testNullByteInKey()`
	`301`	`+ {`
	`302`	`+ $cache = $this->createCachePool(0, __FUNCTION__);`
	`303`	`+`
	`304`	`+ $cache->save($cache->getItem("a\0b")->set(123));`
	`305`	`+`
	`306`	`+ $this->assertSame(123, $cache->getItem("a\0b")->get());`
	`307`	`+ }`
`299`	`308`	`}`
`300`	`309`
`301`	`310`	`class NotUnserializable`