[Profiler][Translation] Logging false by default and desactivated when using the profiler

Amrouche Hamza · Amrouche Hamza · commit ffc6e9b1c944 · 2017-11-01T19:22:20.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/LoggingTranslatorPass.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/LoggingTranslatorPass.php
@@ -27,6 +27,9 @@ public function process(ContainerBuilder $container)
         if (!$container->hasAlias('logger') || !$container->hasAlias('translator')) {
             return;
         }
+        if ($container->has('profiler') && $container->hasParameter('translator.logging')) {
+            $container->setParameter('translator.logging', false);
+        }
 
         if ($container->hasParameter('translator.logging') && $container->getParameter('translator.logging')) {
             $translatorAlias = $container->getAlias('translator');
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -622,7 +622,7 @@ private function addTranslatorSection(ArrayNodeDefinition $rootNode)
                             ->prototype('scalar')->end()
                             ->defaultValue(array('en'))
                         ->end()
-                        ->booleanNode('logging')->defaultValue($this->debug)->end()
+                        ->booleanNode('logging')->defaultValue(false)->end()
                         ->scalarNode('formatter')->defaultValue('translator.formatter.default')->end()
                         ->arrayNode('paths')
                             ->prototype('scalar')->end()
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LoggingTranslatorPassTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LoggingTranslatorPassTest.php
@@ -38,7 +38,7 @@ public function testProcess()
             ->method('getDefinition')
             ->will($this->returnValue($definition));
 
-        $container->expects($this->once())
+        $container->expects($this->atLeastOnce())
             ->method('hasParameter')
             ->with('translator.logging')
             ->will($this->returnValue(true));
@@ -80,6 +80,60 @@ public function testProcess()
         $pass->process($container);
     }
 
+    public function testProcessWithProfiler()
+    {
+        $definition = $this->getMockBuilder('Symfony\Component\DependencyInjection\Definition')->getMock();
+        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->getMock();
+        $parameterBag = $this->getMockBuilder('Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface')->getMock();
+
+        $container->expects($this->exactly(2))
+            ->method('hasAlias')
+            ->will($this->returnValue(true));
+
+        $container->expects($this->once())
+            ->method('getParameter')
+            ->will($this->returnValue(true));
+
+        $container->expects($this->once())
+            ->method('getAlias')
+            ->will($this->returnValue('translation.default'));
+
+        $container->expects($this->exactly(3))
+            ->method('getDefinition')
+            ->will($this->returnValue($definition));
+
+        $container->expects($this->atLeastOnce())
+            ->method('hasParameter')
+            ->with('translator.logging')
+            ->will($this->returnValue(true));
+
+        $container->expects($this->atLeastOnce())
+            ->method('setParameter')
+            ->with('translator.logging')
+            ->will($this->returnValue(true));
+
+        $container->expects($this->atLeastOnce())
+            ->method('has')
+            ->with('profiler')
+            ->will($this->returnValue(true));
+
+        $parameterBag->expects($this->once())
+            ->method('resolveValue')
+            ->will($this->returnValue("Symfony\Bundle\FrameworkBundle\Translation\Translator"));
+
+        $container->expects($this->once())
+            ->method('getParameterBag')
+            ->will($this->returnValue($parameterBag));
+
+        $container->expects($this->once())
+            ->method('getReflectionClass')
+            ->with('Symfony\Bundle\FrameworkBundle\Translation\Translator')
+            ->will($this->returnValue(new \ReflectionClass('Symfony\Bundle\FrameworkBundle\Translation\Translator')));
+
+        $pass = new LoggingTranslatorPass();
+        $pass->process($container);
+    }
+
     public function testThatCompilerPassIsIgnoredIfThereIsNotLoggerDefinition()
     {
         $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->getMock();
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
@@ -152,7 +152,7 @@ protected static function getBundleDefaultConfig()
             'translator' => array(
                 'enabled' => !class_exists(FullStack::class),
                 'fallbacks' => array('en'),
-                'logging' => true,
+                'logging' => false,
                 'formatter' => 'translator.formatter.default',
                 'paths' => array(),
             ),

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@ public function process(ContainerBuilder $container)`
`27`	`27`	`if (!$container->hasAlias('logger') \|\| !$container->hasAlias('translator')) {`
`28`	`28`	`return;`
`29`	`29`	`}`
	`30`	`+ if ($container->has('profiler') && $container->hasParameter('translator.logging')) {`
	`31`	`+ $container->setParameter('translator.logging', false);`
	`32`	`+ }`
`30`	`33`
`31`	`34`	`if ($container->hasParameter('translator.logging') && $container->getParameter('translator.logging')) {`
`32`	`35`	`$translatorAlias = $container->getAlias('translator');`