Fix failing component tests on Travis #12034
Comments
|
@webmozart no we should not. The goal of this test run is precisely to ensure that all dependency constraints in the components' composer.json are right. So we should fix them instead of altering them to force installing a specific version |
|
@stof Yes, I wasn't clear :) The point is: Somebody make the tests green! :) |
|
What about reverting this this BC break, and provide a signature that would be BC for the AuthenticationListener? |
|
@romainneutron This fixes the symptom, but not the problem, no? |
|
Well, the main problem is the BC break actually |
|
@stof Any BC break (even if allowed by our policy) will be a problem unless we find a way to fix this. |
|
Well, if we break BC, we can change the constraints in older branches to change the max allowed version of the dependency. But note that this will only fix it in the testsuite and for new releases of the older version. Previous releases will still advocate compatibility because of using the usage of the semver constraint. |
…ron) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Fix BC break introduced in #10694 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12034 | License | MIT Not sure about this fix, @stof 'ing welcome Commits ------- b2183aa [Security] Fix BC break introduces in #10694
|
re #12542 |
|
Closing as we are all working hard to make the tests green again :) |
Currently, the SecurityBundle tests fail on Travis for versions < master when running the tests in isolation:
The problem is that #10694 broke BC for the master branch. When the tests are run for a lower version than master ("2.3" for example), Composer still installs the dependencies in version "dev-master", resulting in errors due to the BC break.
When running the component tests, we should fix Composer to install the dependencies for the appropriate branch instead of always taking the master branch. Not sure how to do this though.
ping @romainneutron @Seldaek
The text was updated successfully, but these errors were encountered: