Skip to content

[Debug] Ajax debug toolbar ouput garbled / table stylesheets #12139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunetics opened this issue Oct 5, 2014 · 2 comments
Closed

[Debug] Ajax debug toolbar ouput garbled / table stylesheets #12139

lunetics opened this issue Oct 5, 2014 · 2 comments
Labels
WebProfilerBundle

Comments

@lunetics
Copy link

lunetics commented Oct 5, 2014

The ajax debug toolbar uses tables. But i think it's not only me who uses some kind of css-reset script e.g. from Foundation:

table {
    background: none repeat scroll 0 0 #fff;
    border: 1px solid #dcdcdc;
    margin-bottom: 1.25rem;
    table-layout: fixed;
    width: 100%;
}

So that will garble the output:

ajax

Better to refactor to keep the div style like the other toolbar elements?
@lunetics lunetics changed the title [Debug] Ajax debug toolbar styles [Debug] Ajax debug toolbar ouput garbled / table stylesheets Oct 5, 2014
@stof
Copy link
Member

stof commented Oct 5, 2014

the other solution is to force the value of table-layout in the toolbar styles

@1ed 1ed mentioned this issue Dec 8, 2014
Closed
@1ed
Copy link
Contributor

1ed commented Dec 8, 2014

@lunetics could you please check if #12899 fixes this issue as well?

fabpot added a commit that referenced this issue Dec 11, 2014
@fabpot
bug #12899 [WebProfiler] Tweaked ajax requests toolbar css reset (1ed)
4d3d197 
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes #12899).

Discussion
----------

[WebProfiler] Tweaked ajax requests toolbar css reset

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12139 (not sure)
| License       | MIT
| Doc PR        | -

Before:
![screenshot from 2014-12-08 14 52 42](https://cloud.githubusercontent.com/assets/162986/5340221/7b3f1716-7eea-11e4-81c7-f46768736289.png)

After:
![screenshot from 2014-12-08 15 14 35](https://cloud.githubusercontent.com/assets/162986/5340443/fbfb3d1a-7eec-11e4-8960-9990937a49a1.png)

Commits
-------

16a51e7 [WebProfiler] Tweaked ajax requests toolbar css reset
@fabpot fabpot closed this as completed Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @lunetics @1ed @stof