Skip to content

[Security] Why is the username base64–encoded in TokenBasedRememberMeServices? #14577

Closed
@MacDada

Description

@MacDada

Why is the username base64–encoded in https://github.com/symfony/Security/blob/master/Http/RememberMe/TokenBasedRememberMeServices.php#L106 ?

It is actually double encoded because all the cookie's data get encoded after all.

I couldn't find the explanation in git history and the reason isn't obvious (at least to me). Tests say that it is required but they don't say why.

A comment in the code (and/or the TestCase) could be useful – I can make a PR after I understand what's that for.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions