[Translation] Improve the pluralization rule for French #16256

ghost · 2015-10-16T05:04:26Z

The current pluralization rule for French is not exactly right. Numbers like negatives (like -4) and decimals of 1 (like 1.78) should also be considered as singulars, not plurals. Correct me if I'm wrong, but the current rule sets only 0, decimals of 0, and 1, as singulars, and the rest as plurals.

Something like that is better:

return [
    if ($number >= 0 and $number < 2) {
        return 'singular';
    }
    else {
        return 'plural';
    }
]

(Sorry, I'm not a coder, so I can't really provide the appropriate patch myself)

We now use Symfony's Translation component. Yay! We get more powerful pluralisation and better a fallback mechanism. Will want to implement the caching mechanism at some point too. The API is replicated in JavaScript, which could definitely use some testing. Validators have been refactored so that they are decoupled from models completely (i.e. they simply validate arrays of user input). Language packs should include Laravel's validation messages. ref #267

aitboudad · 2015-10-17T08:54:00Z

Hi,
The pluralization rule expect number to be an integer and not a float type.

Numbers decimals: if we pass ($number = (int) 1.78 = 1) should be considered as singulars which is the current behavior.
Numbers negatives: IMO the number should be >= 0

ghost · 2015-10-21T09:32:58Z

I see you closed it, but what's about >= 0?

stof · 2015-10-21T09:33:53Z

CLDR pluralization rules only support non-negative integers. And this is logical: language pluralization rules are based on a quantity, which cannot be negative or non-integer. So there is no way to pass such value in a pluralization rule selector and have it give you a meaningful value.

ghost · 2015-10-21T09:35:51Z

Okay, thanks for the explaination! :)

kylekatarnls · 2019-02-12T18:36:45Z

The pluralization rule expect number to be an integer and not a float type.

It should not! As @ghost explained, 1.5 is singular in French, plural in English, so you can't have both working if you force the integer cast, remove this typing please:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Translation/IdentityTranslator.php#L57

@fabpot There is still a linguistic bug about decimal, this should be re-open and decimal numbers should be properly handled in different languages groups according to language plural rule, not truncated for every language.

aitboudad added the Translation label Oct 17, 2015

aitboudad closed this as completed Oct 21, 2015

kylekatarnls mentioned this issue Feb 12, 2019

[Translation] Floating number plural broken #30215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Translation] Improve the pluralization rule for French #16256

[Translation] Improve the pluralization rule for French #16256

ghost commented Oct 16, 2015

aitboudad commented Oct 17, 2015

ghost commented Oct 21, 2015

stof commented Oct 21, 2015

ghost commented Oct 21, 2015

kylekatarnls commented Feb 12, 2019 •

edited

Loading

[Translation] Improve the pluralization rule for French #16256

[Translation] Improve the pluralization rule for French #16256

Comments

ghost commented Oct 16, 2015

aitboudad commented Oct 17, 2015

ghost commented Oct 21, 2015

stof commented Oct 21, 2015

ghost commented Oct 21, 2015

kylekatarnls commented Feb 12, 2019 • edited Loading

kylekatarnls commented Feb 12, 2019 •

edited

Loading