-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Routing] Add i18n feature #17262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In my experience this is not really as common as it might look. Anyway, if there's already a good bundle, why duplicating efforts in the core? |
I am currently creating a website which need i18n capabilities. Even if today I choose JMSI18nRoutingBundle, if tomorrow i18n capabilities will be include in symfony core, I will glad to switch on an full-supported solution. |
My point is, if there's a third party bundle that does the job well, there's no need to duplicate efforts in the core as it will only add to the already busy schedule of the core team. Symfony's flexibility that lets you to extend it easily is one of its main strengths. Anyway, how would you envision this feature? So far you only described it in basic terms. |
@jakzal Sometimes it could be useful to add it to Symfony like it happened with the Ldap component. For sure Ldap support could be added by a bundle but it was added as official Symfony component. We also have a full ACL support and not everybody really need it. That because not always we should decline such feature requests. I also agree to add full i18n support for routes in Symfony directly. It could be done as extra Symfony component if you think it should not be in the Symfony Standard Edition by default. |
@JHGitty that's precisely why I'm reluctant whenever there's a proposal to add a new component. Ldap doesn't seem to be finished nor stable (see #16735), and ACL is in a process of removing from the core (see #15013). Anyway, I'll repeat myself:
|
I'm closing this issue for the reasons given by @jakzal:
In any case, thanks for proposing this improvement. |
Hi,
Is it possible to add i18n routing feature directly in symfony stack framework ?
i18n routing example :
3 i18n routes for the same controller action :
As Symfony have Router and Translater component, It would be logic that these 2 components works together to provide i18n routing capability.
A few extra bundles provide this feature (like JMSI18nRoutingBundle), but in my opinion this need is very common and could be candidate to the symfony core.
What do you think about that ?
Regards,
David.
The text was updated successfully, but these errors were encountered: