@dunglas

Looks like a bug to me. Maybe can we use our own inflector: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyAccess/StringUtil.php#L147

symfony/property-info does not require symfony/property-access. So you mean we should suggest symfony/property-access just to use its StringUtil?

I suspect doctrine/inflection would be superior (and more specific to the job)...

Of course, the alternative would be just to copy the StringUtil::singularify from PropertyAccess component, and add a note to keep them in sync (do we do that?).

PropertyInfo and PropertyAccess components are often used together. They must have exactly the same behavior regarding singulars, so they must rely on the same inflection backend.

I'm not a fond of copy/pasting the class. Maybe can we extract the StringUtil class to its own tiny component? /cc @fabpot @webmozart

I've just taken another look at this. Maybe we could just use PropertyAccessorInterface::isReadable / isWritable?

A property access extractor (Symfony\Component\PropertyInfo\PropertyAccessExtractorInterface) that uses the PropertyAccess component seems only logical.

@dunglas I noticed that the return value signature for Symfony\Component\PropertyInfo\PropertyAccessExtractorInterface::isReadable / isWritable is bool|null. When should a null value be returned?

To answer my own question:

Maybe we could just use PropertyAccessorInterface::isReadable / isWritable

No. Because that operates at the instance level.

PropertyInfo and PropertyAccess components are often used together.

@dunglas Does that indiciate that they should probably be in the same package? What about moving the new code from PropertyInfo to the older PropertyAccess component?

@webmozart I've no strong opinion about that. Both components are often used together but they are also commonly used separately. They don't solve the exact same problem.

For instance https://github.com/dunglas/php-to-json-schema uses only PropertyInfo and symfony/form (and many other components) only uses PropertyAccess.

I usually prefer a set of small decoupled components able to work together than a big monolith.

What would be the benefit to merge both components?

For this specific issue, having a new component (like proposed in #18260) or relying on a third party library (like Doctrine Inflector) looks like a better solution: pluralizing and singularizing words is something very useful and common (e.g. API Platform use Doctrine Inflector for a lot of things, including routing) and isn't related at all with properties.

@fabpot This was accidentally closed from the commit message.

@webmozart @dunglas

I think it'd be preferrable to use the PropertyAccess component for checking property access (duh...), but currently it only works with an instance. The same functionality is duplicated in PropertyInfo's PropertyAccessExtractorInterface.

But I do not agree that PropertyInfo be merged into PropertyAccess, because its purpose is to provide other types of metadata about the property (e.g. Doctrine, PHPDoc). These features would not be a good fit in PropertyAccess.